Skip to content

Fixing wrong local path detection with 'paket install' - #773

Merged
forki merged 6 commits into
fsprojects:masterfrom
Stift:LocalRelativePathDetection
Apr 14, 2015
Merged

Fixing wrong local path detection with 'paket install'#773
forki merged 6 commits into
fsprojects:masterfrom
Stift:LocalRelativePathDetection

Conversation

@Stift

@Stift Stift commented Apr 13, 2015

Copy link
Copy Markdown
Contributor

Assume you have the following setup.
A Nuget source Externals\NugetStore (i.e. in your repo a local folder is used for some nuget packages) and you start e.g. your paket install in any subdirectory (e.g. Externals). Paket discovers correctly the paket.dependencies file. But it then fails to detect the folder correctly because it tries to combine the relative folder from your start directory (and it tries to look for Externals\Externals\NugetStore) and not in relative to the location paket.dependencies file.
Other paket commands never had any problems with that.

@forki

forki commented Apr 13, 2015

Copy link
Copy Markdown
Member

It's failing on TravisCI. Is that related?

@Stift

Stift commented Apr 13, 2015

Copy link
Copy Markdown
Contributor Author

it's linux/windows related. I have to adapt some unit tests.

@Stift

Stift commented Apr 13, 2015

Copy link
Copy Markdown
Contributor Author

Ok. The Travis build is fine now. Should I also update the documentation? This is not clearly saying that relative pathes are also allowed. I just tried it out and it worked.

@forki

forki commented Apr 13, 2015

Copy link
Copy Markdown
Member

Yes. Please update the docs.
On Apr 13, 2015 10:58 PM, "Christian" notifications@github.com wrote:

Ok. The Travis build is fine now. Should I also update the documentation?
This is not clearly saying that relative pathes are also allowed. I just
tried it out and it worked.


Reply to this email directly or view it on GitHub
#773 (comment).

@Stift

Stift commented Apr 13, 2015

Copy link
Copy Markdown
Contributor Author

From my side everything seems to be okay.

@forki

forki commented Apr 13, 2015

Copy link
Copy Markdown
Member

Cool. Will look at it tomorrow. Thanks a lot.
On Apr 13, 2015 23:16, "Christian" notifications@github.com wrote:

From my side everything seems to be okay.


Reply to this email directly or view it on GitHub
#773 (comment).

forki added a commit that referenced this pull request Apr 14, 2015
Fixing wrong local path detection with 'paket install'
@forki
forki merged commit da29e78 into fsprojects:master Apr 14, 2015
@Stift
Stift deleted the LocalRelativePathDetection branch April 14, 2015 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants