Pull request/refactor update process - #843
Conversation
…tsNew to InstallIntoProjects.
…ions` is already taken).
|
Cool. You also need to add the parameter to the update command
|
|
I'll look into the |
|
Probably also needed in add command (just to keep it aligned) |
|
The |
|
Correct. Would love to receive a pull request
|
|
|
|
The problem with One possible solution would be do to it like FAKE: // define test dlls
let testDlls = !! (testDir + "/Test.*.dll")
Target "xUnitTest" (fun _ ->
testDlls
|> xUnit (fun p ->
{p with
ShadowCopy = false;
HtmlOutput = true;
XmlOutput = true;
OutputDir = testDir })
)What do you think of the syntax of the One important thing to know would be if you want to achieve binary backwards compatibility (which is hard in F#, escpecially for record types, as far as I know), or only source level backwards compatibility like FAKE? UPDATE: I've created Issue #844 (Clean up public API of |
|
we don't need binary backwards compat. There is only Paket.VisualStudio as consumer at the moment. |
|
Okay, then I'll just add more parameters to |
|
After looking a bit into adding As it currently stands, This is also a hint that much of the code from
Because the necessary modifications are a bit of another story (and because I don't want this pull request to get huge), I'd vote to merge this pull request first. |
…e-process Pull request/refactor update process
|
Very cool. Need to try some things.
|
|
Thank you! That was very fast. |
|
I think this broke the default behaviour. |
|
i think I found the issue |
|
ok it's released in 1.7.1 |
2 participants
paket restore --only-referenced
As the title says: This pull requests makes it possible to say:
which is the same as:
paket install--only-referenced
Consequently, it also adds:
which works analogous to
paket restore --only-referenced.Refactorings
To make such additions easier in the future,
InstallProcessandUpdateProcesswere refactored to use the Parameter Object pattern for the different flags (Force,Hard,WithBindingRedirects).The naming for the new record types
InstallerOptionsandSmartInstallOptionsis not optimal, so I'm open for feedback.Testing
I've not yet added tests for the new functionality. I'd be thankful if you could point me to the correct files where tests for
InstallProcessandUpdateProcesssould be added.Compatibility
Dependencies/PublicAPI.fshas been changed in a backwards compatible way by adding two new public members. The changes toInstallProcessandUpateProcessare not backwards compatible, but this is nearly unavoidable due to the quirks of F#.