Skip to content

Exclusion syntax for paket.template files - #882

Merged
forki merged 9 commits into
fsprojects:masterfrom
devboy:feature/exclusion-syntax-template-files
Jun 22, 2015
Merged

Exclusion syntax for paket.template files#882
forki merged 9 commits into
fsprojects:masterfrom
devboy:feature/exclusion-syntax-template-files

Conversation

@devboy

@devboy devboy commented Jun 19, 2015

Copy link
Copy Markdown
Contributor

PR for #880

  • parses -- to exclude files
  • change to !* pattern
  • disallow the space to avoid ambiguity
  • apply pattern/globs during packaging
  • when fixing a relative path (..) append \ to windows drive (C:)
  • how to exclude entire directory

@forki

forki commented Jun 22, 2015

Copy link
Copy Markdown
Member

is this ready to merge?

@devboy

devboy commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

Will push the latest fixes after lunch ;)

@devboy
devboy force-pushed the feature/exclusion-syntax-template-files branch from be5e406 to 65e8edd Compare June 22, 2015 12:53
@devboy

devboy commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

Apart from not matching against directories (!myDir) where you'd have to use (!myDir/*.*) everything should be in. It would probably be enough to fix that in Fake.Globbing without touching this code.

@forki

forki commented Jun 22, 2015

Copy link
Copy Markdown
Member

it's also important to have a bit of documentation for this.

@devboy

devboy commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

👍

@devboy
devboy force-pushed the feature/exclusion-syntax-template-files branch from 7eda764 to 9b5c712 Compare June 22, 2015 13:20
@devboy

devboy commented Jun 22, 2015

Copy link
Copy Markdown
Contributor Author

Is the documentation sufficient?

@forki

forki commented Jun 22, 2015

Copy link
Copy Markdown
Member

Yep thanks a lot

forki added a commit that referenced this pull request Jun 22, 2015
…-files

Exclusion syntax for paket.template files
@forki
forki merged commit b63e370 into fsprojects:master Jun 22, 2015
@forki

forki commented Jun 22, 2015

Copy link
Copy Markdown
Member

very cool. thanks a lot.

released in paket 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants