ref(remix): Drop Remix v1 route-convention handling - #22726
Merged
Conversation
Member
Author
|
run bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4b7c60a. Configure here.
chargome
marked this pull request as ready for review
July 28, 2026 08:42
chargome
requested review from
JPeer264,
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team
July 28, 2026 08:42
andreiborza
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for remix v1 was already dropped a while ago but some code paths survived: the legacy non-underscore
indexroute convention in both the build-time and runtime path converters. On v2 this was also wrong — a literalindex.tsxis a real/indexroute, not the index — so the removal corrects transaction naming as well. Also deletes the now-unreachable vendoredgetRequestMatch/isIndexRequestUrlhelpers.closes #22299