Start migration from cbindgen to bindgen - #85
Merged
Conversation
kvark
reviewed
Mar 29, 2021
Member
|
@devorc this is absolutely critical work, even if it's very routine. I don't know how to express the gratitude to you for doing this! 🥇 |
Member
|
Is this ready to go? |
Collaborator
Author
|
Almost - need to finish porting some of the functions. Will probably be ready by tonight or tomorrow. |
ncharlton02
marked this pull request as ready for review
April 1, 2021 23:26
Contributor
This was referenced Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #78 - has rust types generated by the header instead of vice-versa. Currently still needs a lot of work (most of the original codebase is deleted 😞 ) but I am slowly reimplementing everything with the generated types. Currently the triangle and compute examples should work on Windows and Linux. Anyways, thought I would post this here to get initial thoughts before I finished adding everything.
Big changes
crate::nativemoduleffi/webgpu.hfor things in the webgpu-native headers, andffi/wgpu.hfor stuff unique to wgpu-native)Small Notes
BindGroupImpl->wgc::id::BindGroupId)Stuff that still needs to be added