Fix build on OS X - #47
Merged
Merged
Conversation
Contributor
Author
|
IMHO it might be worth using |
Member
|
I think it should probably be like this? |
bgamari
force-pushed
the
master
branch
5 times, most recently
from
April 17, 2016 13:33
574ec2d to
261147f
Compare
Contributor
Author
|
Yes, I just finished iterating this; it now seems to build. I'll squash the two commits and write a better commit message. |
There were a number of issues there, largely due to the fact that this codepath is CPP-guarded.
Contributor
Author
|
@Rufflewind how does this look? |
Contributor
Author
|
This has been successfully built on Darwin. |
Member
|
Thanks. I might consider adding the warning suppression you suggested. Probably also a good idea to set up OS X testing on Travis in the future. |
Rufflewind
added
type: (1) bug
bgamari
pushed a commit
to bgamari/directory
that referenced
this pull request
Jul 29, 2016
bgamari
pushed a commit
to bgamari/directory
that referenced
this pull request
Jul 29, 2016
bgamari
pushed a commit
to bgamari/directory
that referenced
this pull request
Jul 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was triggered on Darwin.