Skip to content

removing the unnecessary withMVar (#327). - #330

Merged
eborden merged 1 commit into
haskell:2.7from
kazu-yamamoto:revert-withmvar
Jun 25, 2018
Merged

removing the unnecessary withMVar (#327).#330
eborden merged 1 commit into
haskell:2.7from
kazu-yamamoto:revert-withmvar

Conversation

@kazu-yamamoto

Copy link
Copy Markdown
Collaborator

This should fix #327.

mkWeakMVar is not used anymore. So, this code is not necessary.
@kazu-yamamoto
kazu-yamamoto requested a review from eborden June 25, 2018 07:10

@eborden eborden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We also need to port this over to 2.6.x.x, since that is the version that #327 is targeting.

@eborden
eborden merged commit ff2d0ec into haskell:2.7 Jun 25, 2018
@eborden

eborden commented Jun 25, 2018

Copy link
Copy Markdown
Collaborator

I cherry picked this over to 2.6

@eborden

eborden commented Jun 25, 2018

Copy link
Copy Markdown
Collaborator

6ee1901

@kazu-yamamoto
kazu-yamamoto deleted the revert-withmvar branch June 26, 2018 00:58
This was referenced Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants