Add loopback tests for if index - #391
Merged
Merged
Conversation
Not having tests for these functions created a regression on windows. We should be minimally exercising these paths.
Collaborator
|
@eborden we just need to add |
Collaborator
Author
|
Thanks @Mistuke! |
This was referenced Mar 25, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a tests for
ifIndexToNameandifNameToIndex. As expected these are passing on Linux and failing on Windows.We either need to disable these functions for Windows or handle them in that environment. @Mistuke do you have any recommendations?
Related Issues:
#390
haskell/haskell-platform#318 (comment)
#361