Add safe conversions from ShortByteString - #34
Merged
Conversation
hasufell
reviewed
Aug 6, 2025
Author
|
Hm, I somehow doubt that armv7 CI failing is my fault, is it? |
Member
We can ignore armv7. GHC is broken there. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OsString is internally represented as a ShortByteString, however safe conversion functions
fromBytesandfromBytestringwere only present for ByteStrings; when dealing with ShortByteStrings directly this would require a useless conversion to a bytestring first.This PR adds the
fromShortBytesandfromShortBytestringfunctions which create an OsString from ShortByteString, possibly throwing an error on incorrect encoding