Yet another omnibus - #355
Merged
Merged
Conversation
…yway and never on a critical path
|
Don't quite follow all the details here, but overall looks like a good direction! |
Boarders
approved these changes
Jul 17, 2021
parsonsmatt
approved these changes
Jul 19, 2021
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Everything looks like an improvement to me 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly focused on improving and cleaning up the test suite.
I was interested to remove
vectordependency from benchmarks, because I buildtextagainst GHC HEAD, and rebuildingvectorover and over again is not worth it.