Make Lift instances more efficient - #413
Merged
Merged
Conversation
Contributor
|
@phadej could you please review? |
Member
Author
|
The CI failures seem to be due to the change in template-haskell 2.17 for the type of |
Bodigrim
approved these changes
Mar 14, 2022
TeofilC
force-pushed
the
more-efficient-lift
branch
from
March 14, 2022 14:27
453f039 to
607ad17
Compare
Member
Author
|
I've force pushed to squash the fixup commit |
Member
Author
|
Ah dear it seems like I dropped that commit by accident instead of squashing it. I'll fix it in a bit |
Contributor
|
I'll squash all commits any way, so do not worry about that. |
TeofilC
force-pushed
the
more-efficient-lift
branch
from
March 14, 2022 22:46
607ad17 to
98e9cb3
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows the Lift instance to make use of the primitive bytes literals made available since template-haskell 2.16.
It also adds some extra tests to make sure the instance works correctly with multi codepoint characters.
Let me know if you'd like some changes