Make Lift Text work under RebindableSyntax - #534
Merged
Conversation
The Lift Int instance produces a polymorphic literal, which desugars to fromIntegral under RebindableSyntax. Fixing that instance in base may be too much of a breaking change if a lot of code relies on the accidental polymorphism. We can at least fix Lift Text by not relying on Lift Int.
Bodigrim
approved these changes
Jul 28, 2023
Contributor
|
Great! |
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Sep 18, 2024
Previously these Lift instances could not be used with a custom fromInteger introduced by RebindableSyntax. We implement the same workaround as: haskell/text#534 to fix this. Resolves #25272
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Sep 18, 2024
Previously these Lift instances could not be used with a custom fromInteger introduced by RebindableSyntax. We implement the same workaround as: haskell/text#534 to fix this. Resolves #25272
hubot
pushed a commit
to ghc/ghc
that referenced
this pull request
Sep 18, 2024
Previously these Lift instances could not be used with a custom fromInteger introduced by RebindableSyntax. We implement the same workaround as: haskell/text#534 to fix this. Resolves #25272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lift Int instance produces a polymorphic literal, which desugars to fromIntegral under RebindableSyntax. Fixing that instance in base may be too much of a breaking change if a lot of code relies on the accidental polymorphism. We can at least fix Lift Text by not relying on Lift Int.
Fixes #533