Serialise Texts without going through ByteString - #617
Merged
Conversation
alexbiehl
force-pushed
the
alex/put-without-bytestring
branch
from
October 15, 2024 07:14
8d49474 to
f152209
Compare
Contributor
|
@alexbiehl shall we do the same for lazy |
alexbiehl
force-pushed
the
alex/put-without-bytestring
branch
2 times, most recently
from
October 16, 2024 12:55
128e8fc to
a6d3dc2
Compare
Member
Author
|
@Bodigrim I updated the PR. |
alexbiehl
force-pushed
the
alex/put-without-bytestring
branch
from
October 16, 2024 13:08
a6d3dc2 to
9f368e1
Compare
Member
Author
|
I also added property tests for strict and lazy texts. |
Lysxia
approved these changes
Oct 16, 2024
Bodigrim
reviewed
Oct 16, 2024
alexbiehl
force-pushed
the
alex/put-without-bytestring
branch
2 times, most recently
from
October 17, 2024 06:18
8d18425 to
7263ebf
Compare
Lysxia
reviewed
Oct 17, 2024
alexbiehl
force-pushed
the
alex/put-without-bytestring
branch
from
October 17, 2024 15:31
238f116 to
ae791f0
Compare
Bodigrim
approved these changes
Oct 18, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has never been easier. Ever since text is using UTF-8 encoding internally we don't have to go through the intermediate ByteString step. However, we keep deserialisation as is to ensure proper UTF-8'ness.