test: Add integration harness for the node binary - #78
Merged
rustaceanrob merged 1 commit intoJul 20, 2026
Conversation
4 tasks
Contributor
|
Why are these in draft? Direction looks fine to me. |
Contributor
Author
Thanks! I still have it in draft because the tests don't follow the chain yet. I'm working on the next commit which will add |
pzafonte
changed the title
pzafonte
changed the title
pzafonte
marked this pull request as ready for review
July 14, 2026 13:59
Merged
pzafonte
force-pushed
the
integration-test-harness
branch
from
July 19, 2026 12:46
24a7393 to
3d2045e
Compare
pzafonte
changed the title
rustaceanrob
force-pushed
the
integration-test-harness
branch
from
July 20, 2026 12:22
3d2045e to
a4c9c81
Compare
Add a fixture that starts the node on regtest in a temporary datadir, drives it through the cli over the control socket, and stops it on drop. Add two tests that use the fixture. One checks that the node echoes over the control socket and stops on request. The other points the node at a regtest bitcoind started through corepc-node and waits for the daemon to report the incoming connection. corepc-node is pinned to the v30 client to match the Bitcoin Core daemon it talks to.
rustaceanrob
force-pushed
the
integration-test-harness
branch
from
July 20, 2026 12:35
a4c9c81 to
5f1bc48
Compare
Contributor
|
I want to help get these changes in so I force pushed with a few changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a fixture that starts the node on regtest in a temporary datadir, drives it through the cli over the control socket, and stops it on drop.
Adds two tests that use the fixture. One checks that the node echoes over the control socket and stops on request. The other points the node at a regtest
bitcoindstarted throughcorepc-nodeand waits for the daemon to report the incoming connection.corepc-nodeis pinned to the v30 client to match the Bitcoin Core daemon it talks to and uses its download feature sobitcoindis fetched automatically when it isn't already onPATH/BITCOIND_EXEFollowups:
#85
#86