Skip to content

Improve the enqueueing of JS scripts and styles - #161

Merged
dkotter merged 8 commits into
developfrom
enhancement/144
Jun 3, 2025
Merged

Improve the enqueueing of JS scripts and styles#161
dkotter merged 8 commits into
developfrom
enhancement/144

Conversation

@iamdharmesh

Copy link
Copy Markdown
Collaborator

Description of the Change

As reported in #144, the plugin was using PHP files to serve JavaScript and CSS in some places. This PR fixes the issue by properly enqueueing JavaScript scripts and styles.

Closes #144

How to test the Change

Make sure the following features work as expected:

  • Form submission
  • Date picker
  • Form styles
  • Applied custom styles (Note: This is for backward compatibility only, we no longer support this feature.)

Changelog Entry

Changed - Improved the enqueueing of JavaScript scripts and styles.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions Bot added this to the 1.9.0 milestone May 20, 2025
@iamdharmesh
iamdharmesh marked this pull request as ready for review May 20, 2025 11:29
@github-actions github-actions Bot added the needs:code-review This requires code review. label May 20, 2025
@iamdharmesh
iamdharmesh requested a review from dkotter May 20, 2025 11:31
@dkotter
dkotter requested a review from qasumitbagthariya May 20, 2025 14:35
@qasumitbagthariya

Copy link
Copy Markdown
Contributor

QA Update ✅


I have verified this PR in the enhancement/341 branch, which has been fixed and is functioning as intended.

I tested the following on this branch:

  • Form submission
  • Date picker

Form Submission

image

Widget

image

Shortcode

image

Date Picker

Screen.Recording.2025-05-26.at.3.09.58.PM.mov

Testing Environment

Details
  • WordPress: 6.8
  • Theme: Storefront 4.6.1
  • Theme: Twenty Twenty-Four 1.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS 15.2
  • Branch: enhancement/144

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for code UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@github-actions github-actions Bot added the needs:refresh This requires a refreshed PR to resolve. label Jun 3, 2025
@vikrampm1 vikrampm1 mentioned this pull request Jun 3, 2025
21 tasks
@github-actions github-actions Bot removed the needs:refresh This requires a refreshed PR to resolve. label Jun 3, 2025
@dkotter
dkotter merged commit f874acc into develop Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the enqueueing of JS scripts and styles

3 participants