Skip to content

Feature/28297 make error message at a constant or a read only property more specific - #28313

Merged
DanielRosenwasser merged 7 commits into
microsoft:masterfrom
a-tarasyuk:feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
Nov 13, 2018
Merged

Feature/28297 make error message at a constant or a read only property more specific#28313
DanielRosenwasser merged 7 commits into
microsoft:masterfrom
a-tarasyuk:feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #28297

Comment thread src/compiler/diagnosticMessages.json Outdated
Comment thread src/compiler/checker.ts Outdated
@a-tarasyuk
a-tarasyuk force-pushed the feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific branch from 7061101 to 66539b4 Compare November 3, 2018 14:27
@a-tarasyuk

Copy link
Copy Markdown
Contributor Author

@Andy-MS Thanks. I've added requested changes.

@Ishaan28malik Ishaan28malik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done...

@ghost

ghost commented Nov 5, 2018

Copy link
Copy Markdown

@DanielRosenwasser please review (github reviewers section not working right now)

… feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
… feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
@DanielRosenwasser
DanielRosenwasser merged commit 12e371b into microsoft:master Nov 13, 2018
@DanielRosenwasser

Copy link
Copy Markdown
Member

Thank you!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants