Skip to content

[1.29] Fix crash with --disable-interactivity and EFResume - #6303

Merged
JohnMcPMS merged 1 commit into
microsoft:release-v1.29from
Trenly:PickInteractivity129
Jun 22, 2026
Merged

[1.29] Fix crash with --disable-interactivity and EFResume#6303
JohnMcPMS merged 1 commit into
microsoft:release-v1.29from
Trenly:PickInteractivity129

Conversation

@Trenly

@Trenly Trenly commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📖 Description

Cherry Picks #6302 into v1.29

When winget install --disable-interactivity is executed with the Resume experimental feature enabled, checkpoint creation saves all command-line arguments. On resume or during checkpoint validation, the code calls Argument::ForType() on every saved argument type to reconstruct the execution context. However, Execution::Args::Type::DisableInteractivity was missing from the Argument::ForType() switch statement, causing the default case to throw E_UNEXPECTED (0x8000ffff) instead of properly handling the flag.

🔗 References

🔍 Validation

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly changed the title Fix crash with --disable-interactivity and EFResume [1.29] Fix crash with --disable-interactivity and EFResume Jun 19, 2026
@JohnMcPMS
JohnMcPMS marked this pull request as ready for review June 22, 2026 21:58
@JohnMcPMS
JohnMcPMS requested a review from a team as a code owner June 22, 2026 21:58
@JohnMcPMS
JohnMcPMS merged commit b3c35e4 into microsoft:release-v1.29 Jun 22, 2026
4 checks passed
@Trenly
Trenly deleted the PickInteractivity129 branch July 16, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants