Skip to content

fix(core): preserve S3 config and serve nested uploads - #2780

Merged
Innei merged 1 commit into
mx-space:masterfrom
Mizuro-dev:fix-s3-config-and-comment-image-route
Aug 2, 2026
Merged

fix(core): preserve S3 config and serve nested uploads#2780
Innei merged 1 commit into
mx-space:masterfrom
Mizuro-dev:fix-s3-config-and-comment-image-route

Conversation

@Innei

@Innei Innei commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

  • [ ]
  • [ ]

Database migrations checklist (delete if no schema change)

  • Migration is backwards-compatible with the previous release's code
    (rolling deploy: new and old pods coexist during cutover).
  • Drop / rename / type-change is staged across multiple releases
    (expand now, contract in a follow-up release).
  • Indexes on large tables use CREATE INDEX CONCURRENTLY (and break
    out of drizzle's default transaction).
  • pnpm -C apps/core run lint:migrations passes.
  • If migration-lint:allow= is used, reason= explains why and a
    reviewer has agreed.
  • Follow-up contract migration tracked in an issue (if applicable).

See .claude/skills/mx-migration-author/SKILL.md for the expand-contract
decision tree and the spec at
docs/superpowers/specs/2026-05-05-database-migration-release-phase-design.md.

@safedep

safedep Bot commented Aug 2, 2026

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

View complete scan results →

This report is generated by SafeDep Github App

@Innei
Innei merged commit c4e669d into mx-space:master Aug 2, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96e8a6eb11

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bucket: field.halfGrid(nullableStorageText(), 'Bucket'),
region: field
.halfGrid(nullableStorageText(), 'Region')
.transform((value) => value || 'auto'),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the existing region on partial backup patches

When a client PATCHes backupOptions without a region—for example, to change only enable—this transform converts the omitted value from undefined to "auto". patchAndValid() then passes that generated field to patch(), so a previously configured custom S3 region is silently overwritten and subsequent backup uploads may use the wrong region. Keep undefined unchanged while normalizing only an explicitly null or blank region.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant