Skip to content

doc: fix title/function name mismatch - #13123

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc-fix2
Closed

doc: fix title/function name mismatch#13123
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc-fix2

Conversation

@mhdawson

@mhdawson mhdawson commented May 19, 2017

Copy link
Copy Markdown
Member

Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc, n-api

@mhdawson
doc: fix title/function name mismatch
1ad77df 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels May 19, 2017
@mhdawson

mhdawson commented May 23, 2017

Copy link
Copy Markdown
Member Author

CI run: https://ci.nodejs.org/job/node-test-pull-request/8249/

@addaleax

addaleax commented May 23, 2017

Copy link
Copy Markdown
Member

Landed in f3ef971

@addaleax addaleax closed this May 23, 2017
addaleax pushed a commit that referenced this pull request May 23, 2017
@mhdawson @addaleax
doc: fix title/function name mismatch
f3ef971 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request May 24, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
a9b78b2 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
336d33b 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@mhdawson
mhdawson deleted the napi-doc-fix2 branch June 28, 2017 19:23
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@mhdawson Gabriel Schulhof
doc: fix title/function name mismatch
2e48f58 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: nodejs#13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@mhdawson @MylesBorins
doc: fix title/function name mismatch
2e29052 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
Backport-PR-URL: #19447
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Domiii added a commit to replayio/node that referenced this pull request Jul 30, 2026
@Domiii
RQD-14: pin REPLAY_BACKEND_REV to backend master after nodejs#13123.
039f488
Domiii added a commit to replayio/node that referenced this pull request Jul 30, 2026
@Domiii @cursoragent
RQD-14: Buildkite Migration + test fixes + -dev buildId suffix (#127)
469573c 
* Assert TLSWrap EncOut and StreamBase Write buffer counts

Narrow nbufs mismatch provenance before uv__try_write (crash-0044).

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: add runtime-node-build-and-test PipelineUpload + DevSuffix.

Chromium-twin BK graph in public node; pin BackendBranch for driver/build/test handoff.

* RQD-14: PipelineUpload fetch pin/YAML without full node checkout.

* RQD-14: match existing BK step labels (no invented trigger label).

* RQD-14: clone node in parallel with build-driver-linker.

* RQD-14: drop replay-deploy plugin from PR Build node step.

* RQD-14: wipe node-src before Clone node (skip-checkout dirty workdir).

* RQD-14: use per-job mktemp scratch dirs (agents are stateful).

* RQD-14: drop Clone node artifact handoff; build_node_builder clones.

* RQD-14: DriverBuildCheck — skip build-driver-linker when archive on S3.

* RQD-14: quote DriverBuildCheck command (YAML colon parse).

* RQD-14: raise Build node timeout to 120m (cold make exceeds BK 60m default).

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: persist host NodeRepo for incremental make across CI jobs.

Mount the agent checkout+out over the image node path so cold full rebuilds are not forced every run.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: mark mounted NodeRepo safe.directory for root docker git.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin backend safe.directory fix; drop ineffective GIT_CONFIG_*.

Container git lacks GIT_CONFIG_*; safe.directory is set in run_node_build.sh.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: stop injecting github-backend AWS keys into linux-node-build.

prod/deploy-access-keys cannot s3:PutObject builds/; match build-node.yml and use the beefmaster agent identity inside docker.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin configure-skip; give tests HASURA_ADMIN_SECRET.

Skip configure when out/Makefile exists for incremental NodeRepo make. Test steps need Hasura secret (ProcessorExit cascade without it).

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: mtime-safe NodeRepo fetch; log disk at build start.

Drop shallow fetch on the cached repo (it rewrote gyp mtimes and forced Makefile regen). Unshallow once if needed. df/du at job start for disk headroom.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: restore accidentally deleted GHA build-test files.

Prior commit had unrelated staged deletions; keep additive pipeline work only.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: stop chown-ctime from forcing full NodeRepo checkout.

reclaim_node_repo chown -R dirties every path via ctime; checkout -f then
rewrote all 32k sources and triggered Regenerating Makefile. Ignore ctime
and refresh the index after reclaim.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin backend after local/test crash-upload skip.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin backend after reverting crash-upload skip.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin backend for __fread_chk binding.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin backend after deploy-agent driver builds.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: seed immer Jest repo for test-jest; pin backend.

* RQD-14: pin backend for napi_create_array callback.

* RQD-14: pin backend for unimplemented NAPI callback specs.

* RQD-14: pin backend for dl_iterate_phdr NoOp binding.

* RQD-14: immer npm install --legacy-peer-deps for test-jest.

* RQD-14: drop prefer-offline for immer npm install.

BK agent cache returns ETARGET for @types/node@24.3.1 which exists on the registry.

* RQD-16: pin immer v9.0.12 and yarn-install for test-jest seed.

Floating main is vitest-era and never produces node_modules/.bin/jest.

Co-authored-by: Cursor <cursoragent@cursor.com>

* RQD-14: pin REPLAY_BACKEND_REV to backend master after nodejs#13123.

* RQD-14: re-pin REPLAY_BACKEND_REV to current backend master.

* RQD-14: disable legacy GHA Build/Test on PR/push.

Replaced by Buildkite runtime-node-build-and-test; keep workflow_dispatch only.

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@refack refack refack approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson @addaleax @refack @jasnell @lpinca @cjihrig @gibfahn @nodejs-github-bot