Skip to content

lib: fix typos - #38846

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
bl-ue:fix-lib-typos
Jun 1, 2021
Merged

lib: fix typos#38846
aduh95 merged 1 commit into
nodejs:masterfrom
bl-ue:fix-lib-typos

Conversation

@bl-ue

@bl-ue bl-ue commented May 29, 2021

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels May 29, 2021
bl-ue
bl-ue commented May 31, 2021
View reviewed changes
Comment thread lib/internal/util/comparisons.js Outdated
mhdawson
mhdawson approved these changes May 31, 2021
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bl-ue

bl-ue commented May 31, 2021

Copy link
Copy Markdown
Contributor Author

What's stopping this PR from being merged? It has 8 approvals (👀) — is it that it's been open for 46.5 (not 48) hours?

@aduh95

aduh95 commented May 31, 2021

Copy link
Copy Markdown
Contributor

is it that it's been open for 46.5 (not 48) hours?

Exactly:

✔  Done loading data for nodejs/node/pull/38846
----------------------------------- PR info ------------------------------------
Title      lib: fix typos (#38846)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     bl-ue:fix-lib-typos -> nodejs:master
Labels     needs-ci, util
Commits    1
 - lib: fix typos
Committers 1
 - bl-ue <54780737+bl-ue@users.noreply.github.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 29 May 2021 20:07:54 GMT
   ✔  Approvals: 8
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/38846#pullrequestreview-671771955
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/38846#pullrequestreview-671809238
   ✔  - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/38846#pullrequestreview-671834103
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/38846#pullrequestreview-671840917
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/38846#pullrequestreview-671841326
   ✔  - Khaidi Chu (@XadillaX): https://github.com/nodejs/node/pull/38846#pullrequestreview-672255395
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/38846#pullrequestreview-672350853
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/38846#pullrequestreview-672435369
   ✖  This PR needs to wait 41 more minutes to land

@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label May 31, 2021
@bl-ue @aduh95
lib: fix typos
dccf64e 
PR-URL: #38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@aduh95

aduh95 commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

Landed in dccf64e

@aduh95
aduh95 merged commit dccf64e into nodejs:master Jun 1, 2021
@bl-ue
bl-ue deleted the fix-lib-typos branch June 1, 2021 12:24
danielleadams pushed a commit that referenced this pull request Jun 1, 2021
@bl-ue @danielleadams
lib: fix typos
08ad2f6 
PR-URL: #38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadams danielleadams mentioned this pull request Jun 1, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@bl-ue @richardlau
lib: fix typos
fbe678f 
PR-URL: #38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@bl-ue @richardlau
lib: fix typos
b0df4b2 
PR-URL: #38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@bl-ue @richardlau
lib: fix typos
b0a1984 
PR-URL: #38846
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@targos targos targos approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@XadillaX XadillaX XadillaX approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bl-ue @aduh95 @jasnell @Trott @targos @cjihrig @XadillaX @richardlau @mhdawson @RaisinTen