Fix incorrect parallax config migration - #38518
Merged
Merged
Conversation
See https://sentry.ppy.sh/organizations/ppy/issues/146906 (would show up as an ugly generic "error occurred" notification on every start-up). Magic bindable config API strikes once more. `1` and `0` literals are inferred to be `int` in generic contexts, which then fails at trying to get the target bindable as `Bindable<int>` instead of `Bindable<float>`. This is invisible in debug because config migrations do not run in debug.
bdach
added
the
type/reliability
peppy
approved these changes
Aug 4, 2026
github-project-automation
Bot
moved this from Pending Review
to Done
in osu! team task tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://sentry.ppy.sh/organizations/ppy/issues/146906 (would show up as an ugly generic "error occurred" notification on every start-up).
Magic bindable config API strikes once more.
1and0literals are inferred to beintin generic contexts, which then fails at trying to get the target bindable asBindable<int>instead ofBindable<float>.This is invisible in debug because config migrations do not run in debug.