Skip to content

bpo-36974: add some assertions for PEP 590 - #13682

Merged
encukou merged 1 commit into
python:masterfrom
jdemeyer:pep590_assert
Jun 2, 2019
Merged

bpo-36974: add some assertions for PEP 590#13682
encukou merged 1 commit into
python:masterfrom
jdemeyer:pep590_assert

Conversation

@jdemeyer

@jdemeyer jdemeyer commented May 30, 2019

Copy link
Copy Markdown
Contributor

@jdemeyer

Copy link
Copy Markdown
Contributor Author

CC @encukou

@encukou

encukou commented May 31, 2019

Copy link
Copy Markdown
Member

Is it better to have the checks here than in _PyType_CheckConsistency?

@encukou

encukou commented Jun 2, 2019

Copy link
Copy Markdown
Member

The answer is in the comment – "we require this before inheriting". I now agree that's a good thing to do.

@encukou
encukou merged commit be718c3 into python:master Jun 2, 2019
@jdemeyer
jdemeyer deleted the pep590_assert branch June 17, 2019 09:57
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants