Deprecate comparing Gem::Version objects with strings - #9085
Merged
Conversation
tenderlove
force-pushed
the
deprecate-str-cmp
branch
from
November 16, 2025 20:29
c36d3d3 to
42572a9
Compare
tenderlove
force-pushed
the
deprecate-str-cmp
branch
4 times, most recently
from
November 16, 2025 23:33
27bbcb4 to
704e8ae
Compare
Comparing version objects is a huge bottleneck in dependency solvers
(like inside Bundler). I would like to make comparing version objects
cheaper. Right now we support comparing version objects with strings by
trying to coerce the string to a version. So for example:
```ruby
Gem::Version.new("1") <=> "12"
```
I would like to deprecate and remove support for this feature so that we
can reduce the overhead of `def <=>`.
I'm not sure what version of RubyGems we could remove this from though.
tenderlove
force-pushed
the
deprecate-str-cmp
branch
from
November 17, 2025 00:03
f7921ec to
df9da7f
Compare
colby-swandale
approved these changes
Nov 17, 2025
hsbt
approved these changes
Nov 21, 2025
hsbt
left a comment
hsbt
left a comment
Member
There was a problem hiding this comment.
We may disable that feature about 3-4 years later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing version objects is a huge bottleneck in dependency solvers (like inside Bundler). I would like to make comparing version objects cheaper. Right now we support comparing version objects with strings by trying to coerce the string to a version. So for example:
I would like to deprecate and remove support for this feature so that we can reduce the overhead of
def <=>.I'm not sure what version of RubyGems we could remove this from though.