Skip to content

fix: relax yamllint rules for Psych-generated YAML - #94

Merged
ineedjet merged 3 commits into
mainfrom
fix/yamllint-psych-compat
Jul 3, 2026
Merged

fix: relax yamllint rules for Psych-generated YAML#94
ineedjet merged 3 commits into
mainfrom
fix/yamllint-psych-compat

Conversation

@ineedjet

@ineedjet ineedjet commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #93

Changes to config/yamllint.yml

  • document-start: disable — Psych always emits ---; previously this was an error. Both with and without --- now pass.
  • indentation.indent-sequences: consistent — Psych outputs sequences at the same level as the parent key. consistent requires uniformity within each file rather than enforcing a specific style, so both Psych-style and human-written YAML pass.

Result

i18n-tasks normalize and yamllint are no longer mutually exclusive. .rubocop_todo.yml also passes without manual reformatting.

🤖 Generated with Claude Code

ineedjet and others added 2 commits July 4, 2026 00:13
- document-start: disable — Psych always emits ---; both styles now allowed
- indentation.indent-sequences: consistent — Psych uses non-indented sequences;
  consistent enforces uniformity within a file rather than a fixed style

Closes #93

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ERRIDES.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a8a7b4e51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread config/yamllint.yml Outdated
present: false
document-start: disable
indentation:
spaces: 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve flexible YAML indentation

🤖 [rubykatzen/baseline]: This sets the inherited yamllint indentation.spaces default from consistent to a fixed 2 spaces. I checked yamllint 1.38 docs: an integer spaces value represents the required indentation width, while the default consistent allows any width that stays uniform within the file. In consuming repos with otherwise valid, consistently 4-space YAML, the shared lint-yamllint action/pre-commit hook will now fail even though this change is meant to relax Psych-generated YAML; keep spaces: consistent or omit it and only adjust indent-sequences.

Useful? React with 👍 / 👎.

Comment thread config/yamllint.yml
document-start:
level: error
present: false
document-start: disable

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the disabled document-start rule

🤖 [rubykatzen/baseline]: Disabling document-start changes a yamllint default, but LINTERS-DEFAULTS-OVERRIDES.md still documents only line-length under yamllint. AGENTS.md explicitly requires disabled rules/default deviations to be recorded there, so consumers will not see why document markers are allowed unless this row is added with the Psych rationale.

Useful? React with 👍 / 👎.

Fixed value breaks repos using 4-space YAML; yamllint default
(consistent) is correct — enforce uniformity, not a specific width.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ineedjet
ineedjet merged commit b142bef into main Jul 3, 2026
1 check passed
@ineedjet
ineedjet deleted the fix/yamllint-psych-compat branch July 3, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yamllint config is incompatible with Ruby/Psych-generated YAML files

1 participant