Update println! calls to dbg! where appropriate - #2842
Closed
mikemorris wants to merge 5 commits into
Closed
Conversation
Contributor
|
I did some println changes in #3048, and some might conflict. Not sure which should be used where... I guess anything that doesn't print additional information should use |
carols10cents
added a commit
that referenced
this pull request
Jun 4, 2022
carols10cents
added a commit
that referenced
this pull request
Jun 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started working on this locally on an older checkout and then discovered it was mostly added in 5813399 so rebased to resolve the conflict with the newer explanation, but can still help finish updating the later references to close #1658
Initially searched for matches on
{:to target pretty-prints, then against plainprintln!("{}",calls that could be included too. Some remaining cases may exist but currently print additional context or could be a little more ambiguous. Ignored usage prior to introducingdbg!in chapter 5.Checked and decided not to update:
println!calls appear to be part of the core program logic, not just debug outputprintln!calls appear to be part of the core program logic, not just debug output