Update TOML parser to pick up a bugfix - #2680
Conversation
|
r? @brson |
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #2691) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #2743) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit c17f9f0 has been approved by |
|
⌛ Testing commit c17f9f0 with merge a00992f... |
|
💔 Test failed - cargo-win-msvc-64 |
c17f9f0 to
0fa6f27
Compare
|
@bors: r=brson |
|
📌 Commit 0fa6f27 has been approved by |
|
⌛ Testing commit 0fa6f27 with merge 0de788d... |
|
💔 Test failed - cargo-mac-32 |
Cargo has previously accepted invalid TOML as valid, but this bugfix should fix the problem. In order to prevent breaking all crates immediately toml-rs has a compatibility mode which emulates the bug that was fixed. Cargo will issue a warning if this compatibility is required to parse a crate.
0fa6f27 to
2a1e16c
Compare
|
@bors: r=brson On Sun, Jun 12, 2016 at 1:02 PM, bors notifications@github.com wrote:
|
|
📌 Commit 2a1e16c has been approved by |
Update TOML parser to pick up a bugfix Cargo has previously accepted invalid TOML as valid, but this bugfix should fix the problem. In order to prevent breaking all crates immediately toml-rs has a compatibility mode which emulates the bug that was fixed. Cargo will issue a warning if this compatibility is required to parse a crate.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
- `set_require_newline_after_table` was added in rust-lang#2680 back in 2016 - `set_allow_duplicate_after_longer_table` was added in rust-lang#6761 in 2019 Several years later, this PR is turning these warnings into errors. The function and documentation was kept so we can add additional hacks in the future, like if we switch TOML parsers.
Remove TOML incompatibility hacks - `set_require_newline_after_table` was added in #2680 back in 2016 - `set_allow_duplicate_after_longer_table` was added in #6761 in 2019 Several years later, this PR is turning these warnings into errors. The function and documentation was kept so we can add additional hacks in the future, like if we switch TOML parsers.
5 participants
Cargo has previously accepted invalid TOML as valid, but this bugfix should fix
the problem. In order to prevent breaking all crates immediately toml-rs has a
compatibility mode which emulates the bug that was fixed. Cargo will issue a
warning if this compatibility is required to parse a crate.