Skip to content

Proptest 0.9.0, minimal Rust 1.32.0 - #6636

Closed
dwijnand wants to merge 2 commits into
rust-lang:masterfrom
dwijnand:proptest-0.9
Closed

Proptest 0.9.0, minimal Rust 1.32.0#6636
dwijnand wants to merge 2 commits into
rust-lang:masterfrom
dwijnand:proptest-0.9

Conversation

@dwijnand

@dwijnand dwijnand commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

No description provided.

dependabot-support and others added 2 commits February 4, 2019 06:30
@rust-highfive

Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

r=me w/ green CI

@dwijnand

dwijnand commented Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

Ah, breaking changes in rand making a (transitive?) dependency on rand_isaacs break. Oh well.

@Eh2406

Eh2406 commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

This is unfortunate, I was looking forward to using some of the new toys in 0.9.1

@dwijnand

Copy link
Copy Markdown
Contributor Author

How are problems like this resolved in Rust?

@Eh2406

Eh2406 commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

It looks like it is just minimal-versions that is not passing. As this is an unstable feature there is not yet much advice on how to fix it. Fundamentally, rand_isaac-0.1.0 is lying about the minimum version of SeedableRng that it supports.

@Eh2406

Eh2406 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

From a quick look rand 0.6.x is a hot mess with incorrect minimal-versions.

@dwijnand

Copy link
Copy Markdown
Contributor Author

Ok I spent a long time trying to make it work, following your guide in #5657 (comment) and reading lots of commits, comments and threads, and couldn't figure it out. If you have an advice I can continue trying.

@Eh2406

Eh2406 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Thanks for spending the time! I spent some time trying to figure it out as well, but did not get far.

Eh2406 added a commit to Eh2406/cargo that referenced this pull request Mar 16, 2019
This is a rework of rust-lang#6636 now possible do to the change in testing from rust-lang#6748
@Eh2406 Eh2406 mentioned this pull request Mar 16, 2019
bors added a commit that referenced this pull request Mar 16, 2019
Proptest 0.9.1

This is a rework of #6636 now possible do to the change in testing from #6748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants