This repository was archived by the owner on May 23, 2024. It is now read-only.
ices/96395.sh: fixed with no errors - #1243
Merged
Merged
Conversation
=== stdout === === stderr === ==============
Member
|
@matthiaskrgr any idea what's going on here? I cannot make sense of this |
Member
|
Is it actually fixed? Or does glacier report wrongly? |
Member
|
On the current nightly it doesn't ICE, so glacier is correctly reporting it I would say. But it's flipping between fixed/not fixed on various nightlies so tomorrow who knows |
Member
|
The Ok/ICE output was from me testing manually, I don't think it's nondeterministic either as I got the same results twice |
Member
|
Interesting, it's worth reporting it to upstream and maybe adding a regression test quickly 🤔 |
Member
|
Tested on UI tests on rust-lang/rust and yes, it seems fixed. |
Alexendoo
approved these changes
May 11, 2022
Alexendoo
left a comment
Member
There was a problem hiding this comment.
I'll merge this since it's flaky
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…rrors,oli-obk Add regression test for rust-lang#96395 Closes rust-lang#96395 This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment) I think it's good to add a test before regressing again. r? `@compiler-errors` for quick reviiew cc `@oli-obk` you might want to check as you're familiar with MIR
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…rrors,oli-obk Add regression test for rust-lang#96395 Closes rust-lang#96395 This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment) I think it's good to add a test before regressing again. r? ``@compiler-errors`` for quick reviiew cc ``@oli-obk`` you might want to check as you're familiar with MIR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rust-lang/rust#96395