Rustup - #2281
Merged
Merged
Conversation
RalfJung
commented
Jun 29, 2022
| = note: inside `std::panicking::rust_panic_with_hook` at RUSTLIB/std/src/panicking.rs:LL:CC | ||
| = note: inside closure at RUSTLIB/std/src/panicking.rs:LL:CC | ||
| = note: inside `std::sys_common::backtrace::__rust_end_short_backtrace::<[closure@std::rt::begin_panic<&str>::{closure#0}], !>` at RUSTLIB/std/src/sys_common/backtrace.rs:LL:CC | ||
| = note: inside `std::rt::begin_panic::<&str>` at RUSTLIB/std/src/panicking.rs:LL:CC |
Member
Author
There was a problem hiding this comment.
We now prune a but more than before since we remove all #[caller_location] frames, not just the ones at the top. IMO that makes sense. If it doesn't, we should also adjust the same in CTFE.
Cc @saethlin
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit f389d46 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 29, 2022
Rustup Fix our stacktrace after rust-lang/rust#98549. Now we can control whether `caller_location` should be pruned!
Contributor
Contributor
|
💔 Test failed - checks-actions |
Member
Author
|
@bors r+ |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
|
📌 Commit f389d46 has been approved by |
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit 839c120 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix our stacktrace after rust-lang/rust#98549. Now we can control whether
caller_locationshould be pruned!