Skip to content

Fix breakage due to rust-lang/rust#61856 - #4306

Merged
bors merged 1 commit into
masterfrom
unknown repository
Jul 30, 2019
Merged

Fix breakage due to rust-lang/rust#61856#4306
bors merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 30, 2019

Copy link
Copy Markdown

changelog: none

@ghost

ghost commented Jul 30, 2019

Copy link
Copy Markdown
Author

It looks like rust-lang/rust#61856 broke Map::is_argument(..). Part of this fix should be reverted when that gets fixed. Also, I expected the dogfood test to warn for single_match_else in the is_argument function. Maybe it's a false negative or we're not checking for pedantic lints.

@flip1995

Copy link
Copy Markdown
Member

We check for pedantic lints in dogfood, and this should trigger the lint, weird...

.args(&["-D", "clippy::pedantic"])

@bors r+ p=1

@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 2f5c1d0 has been approved by flip1995

@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2f5c1d0 with merge b004461...

bors added a commit that referenced this pull request Jul 30, 2019
@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@flip1995

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2f5c1d0 with merge c9c547e...

bors added a commit that referenced this pull request Jul 30, 2019
@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@flip1995

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2f5c1d0 with merge e7d153a...

bors added a commit that referenced this pull request Jul 30, 2019
@bors

bors commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing e7d153a to master...

@bors
bors merged commit 2f5c1d0 into rust-lang:master Jul 30, 2019
@ghost
ghost deleted the fix-breakage-20190730 branch July 31, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants