Skip to content

Import rustc_plugin from its new location - #4416

Merged
phansch merged 1 commit into
rust-lang:masterfrom
SimonSapin:plugin
Aug 20, 2019
Merged

Import rustc_plugin from its new location#4416
phansch merged 1 commit into
rust-lang:masterfrom
SimonSapin:plugin

Conversation

@SimonSapin

Copy link
Copy Markdown
Contributor

Depends on rust-lang/rust#62727

changelog: none

@phansch

phansch commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 08d8ffc has been approved by phansch

@bors

bors commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 08d8ffc with merge b1d735d...

bors added a commit that referenced this pull request Aug 20, 2019
Import rustc_plugin from its new location

Depends on rust-lang/rust#62727

changelog: none
@bors

bors commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@phansch

phansch commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

The RLS integration failed because.. it needs to be updated to a Clippy version that contains this Clippy PR.

Since everything else passed, I'm going to merge this PR manually and file a rls PR.

@phansch
phansch merged commit 1055cf5 into rust-lang:master Aug 20, 2019
bors added a commit that referenced this pull request Aug 20, 2019
Disable RLS integration test

until RLS has been updated to the latest Clippy commit.

cc #4416 (comment)

changelog: none
@SimonSapin
SimonSapin deleted the plugin branch August 20, 2019 15:15
@SimonSapin

Copy link
Copy Markdown
Contributor Author

I thought rust-lang/rust#62727 was not in Nightly yet?

@tesuji

tesuji commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

We use master rustc, not nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants