run-make tests ignore --test-codegen-backend

[bjorn3]

If I do ./x.py test tests/run-make --test-codegen-backend cranelift, all tests pass, despite the fact that several run-make tests are broken with cg_clif for various reasons.

[hkBst]

I tried reproducing this on dev-desktop-eu-1:

$ x test tests/run-make --test-codegen-backend cranelift

Details

Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.08s Building stage1 compiler artifacts (stage0 -> stage1, aarch64-unknown-linux-gnu) Finished `release` profile [optimized + debuginfo] target(s) in 0.33s Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`) Building stage1 codegen backend cranelift (stage0 -> stage1, aarch64-unknown-linux-gnu) Finished `release` profile [optimized + debuginfo] target(s) in 0.06s Building stage1 run_make_support (stage0 -> stage1, aarch64-unknown-linux-gnu) Finished `release` profile [optimized + debuginfo] target(s) in 0.19s Building stage1 library artifacts (stage1 -> stage1, aarch64-unknown-linux-gnu) Compiling core v0.0.0 (/home/gh-hkBst/rust/library/core) Compiling compiler_builtins v0.1.160 (/home/gh-hkBst/rust/library/compiler-builtins/compiler-builtins) error: 128bit atomics not yet supported --> library/core/src/sync/atomic.rs:3892:23 | 3892 | SeqCst => intrinsics::atomic_load::(dst), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

terminator _0 = intrinsics::atomic_load::<T, AtomicOrdering::SeqCst>(move _1) -> [return: bb7, unwind unreachable]
fn sync::atomic::atomic_load(_1: *const T, _2: sync::atomic::Ordering) -> T {
debug dst => _1;
debug order => _2;
let mut _0: T;
let mut _3: isize;
let _4: !;
let mut 5: fmt::Arguments<'>;
let _6: !;
let mut 7: fmt::Arguments<'>;
let mut _8: &str;
let mut 17: &str;
scope 1 (inlined fmt::Arguments::<'>::from_str) {
debug s => _8;
let mut _9: ptr::non_null::NonNull;
let mut _10: *const u8;
let mut 11: ptr::non_null::NonNull<fmt::rt::Argument<'>>;
let mut _12: usize;
let mut _13: usize;
let mut _14: usize;
scope 2 (inlined str::::as_ptr) {
debug self => _8;
Building [======> ] 10/36: compiler_builtins, core let mut _15: *const str;
}
scope 3 (inlined str::::len) {
debug self => _8;
let _16: &[u8];
scope 4 (inlined str::::as_bytes) {
debug self => 8;
}
}
}
scope 5 (inlined fmt::Arguments::<'>::from_str) {
debug s => _17;
let mut _18: ptr::non_null::NonNull;
let mut _19: *const u8;
let mut 20: ptr::non_null::NonNull<fmt::rt::Argument<'>>;
let mut _21: usize;
let mut _22: usize;
let mut _23: usize;
scope 6 (inlined str::::as_ptr) {
debug self => _17;
let mut _24: *const str;
}
scope 7 (inlined str::::len) {
debug self => _17;
let _25: &[u8];
scope 8 (inlined str::::as_bytes) {
debug self => _17;
}
}
}

bb0: {
    _3 = discriminant(_2);
    switchInt(move _3) -> [0: bb6, 1: bb3, 2: bb5, 3: bb2, 4: bb4, otherwise: bb1];
}

bb1: {
    unreachable;
}

bb2: {
    StorageLive(_7);
    StorageLive(_8);
    _8 = const "there is no such thing as an acquire-release load";
    StorageLive(_9);
    StorageLive(_10);
    StorageLive(_15);
    _15 = &raw const (*_8);
    _10 = copy _15 as *const u8 (PtrToPtr);
    StorageDead(_15);
    _9 = copy _10 as ptr::non_null::NonNull<u8> (Transmute);
    StorageDead(_10);
    StorageLive(_11);
    StorageLive(_12);
    StorageLive(_13);
    StorageLive(_14);
    StorageLive(_16);
    _16 = const "there is no such thing as an acquire-release load" as &[u8] (Transmute);
    _14 = PtrMetadata(copy _16);
    StorageDead(_16);
    _13 = Shl(move _14, const 1_i32);
    StorageDead(_14);
    _12 = BitOr(move _13, const 1_usize);
    StorageDead(_13);
    _11 = move _12 as ptr::non_null::NonNull<fmt::rt::Argument<'_>> (Transmute);
    StorageDead(_12);
    _7 = fmt::Arguments::<'_> { template: move _9, args: move _11 };
    StorageDead(_11);
    StorageDead(_9);
    StorageDead(_8);
    _6 = panicking::panic_fmt(move _7) -> unwind continue;
}

bb3: {
    StorageLive(_5);
    StorageLive(_17);
    _17 = const "there is no such thing as a release load";
    StorageLive(_18);
    StorageLive(_19);
    StorageLive(_24);
    _24 = &raw const (*_17);
    _19 = copy _24 as *const u8 (PtrToPtr);
    StorageDead(_24);
    _18 = copy _19 as ptr::non_null::NonNull<u8> (Transmute);
    StorageDead(_19);
    StorageLive(_20);
    StorageLive(_21);
    StorageLive(_22);
    StorageLive(_23);
    StorageLive(_25);
    _25 = const "there is no such thing as a release load" as &[u8] (Transmute);
    _23 = PtrMetadata(copy _25);
    StorageDead(_25);
    _22 = Shl(move _23, const 1_i32);
    StorageDead(_23);
    _21 = BitOr(move _22, const 1_usize);
    StorageDead(_22);
    _20 = move _21 as ptr::non_null::NonNull<fmt::rt::Argument<'_>> (Transmute);
    StorageDead(_21);
    _5 = fmt::Arguments::<'_> { template: move _18, args: move _20 };
    StorageDead(_20);
    StorageDead(_18);
    StorageDead(_17);
    _4 = panicking::panic_fmt(move _5) -> unwind continue;
}

bb4: {
    _0 = intrinsics::atomic_load::<T, intrinsics::AtomicOrdering::SeqCst>(move _1) -> [return: bb7, unwind unreachable];
}

bb5: {
    _0 = intrinsics::atomic_load::<T, intrinsics::AtomicOrdering::Acquire>(move _1) -> [return: bb7, unwind unreachable];
}

bb6: {
    _0 = intrinsics::atomic_load::<T, intrinsics::AtomicOrdering::Relaxed>(move _1) -> [return: bb7, unwind unreachable];
}

bb7: {
    return;
}

}

alloc13297 (size: 49, align: 1) {
0x00 │ 74 68 65 72 65 20 69 73 20 6e 6f 20 73 75 63 68 │ there is no such
0x10 │ 20 74 68 69 6e 67 20 61 73 20 61 6e 20 61 63 71 │ thing as an acq
0x20 │ 75 69 72 65 2d 72 65 6c 65 61 73 65 20 6c 6f 61 │ uire-release loa
0x30 │ 64 │ d
}

alloc13296 (size: 40, align: 1) {
0x00 │ 74 68 65 72 65 20 69 73 20 6e 6f 20 73 75 63 68 │ there is no such
0x10 │ 20 74 68 69 6e 67 20 61 73 20 61 20 72 65 6c 65 │ thing as a rele
0x20 │ 61 73 65 20 6c 6f 61 64 │ ase load
}

error: could not compile core (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: unsupported builtin codegen backend llvm

error: Failed to assemble `.globl rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0
.type rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0,@function
.section .text.rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0,"ax",@progbits
rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0:
stp fp, lr, [sp, #-32]!
mov fp, sp
str x19, [sp, #24]
mov x19, x0
ldr q0, [x19, 0x0]
frintn d0, d0
str q0, [x19, 0x0]
ldr x19, [sp, #24]
ldp fp, lr, [sp], #32
ret
.size rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0, .-rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0
.text

   `

error: could not compile compiler_builtins (lib) due to 1 previous error
Build completed unsuccessfully in 0:01:22

[bjorn3]

Try applying https://github.com/rust-lang/rust/blob/main/compiler/rustc_codegen_cranelift/patches/0027-stdlib-128bit-atomic-operations.patch

[hkBst]

@bjorn3 that helps, but still leaves the compiler-builtin failure:

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: unsupported builtin codegen backend `llvm`

error: Failed to assemble `.globl rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0
       .type rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0,@function
       .section .text.rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0,"ax",@progbits
       rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0:
           stp fp, lr, [sp, #-32]!
           mov fp, sp
           str x19, [sp, #24]
           mov x19, x0
           ldr q0, [x19, 0x0]
       frintn d0, d0
           str q0, [x19, 0x0]
           ldr x19, [sp, #24]
           ldp fp, lr, [sp], #32
           ret
       .size rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0, .-rint__inline_asm_compiler_builtins__7123b3def08d2128_cgu__098_n0
       .text
       
       
       `

error: could not compile `compiler_builtins` (lib) due to 1 previous error

[bjorn3]

You can either enable the LLVM backend or set CG_CLIF_FORCE_GNU_AS=1 to use as rather than LLVM through cg_llvm as assembler.