Tracking Issue for `PathBuf::into_string`

[asder8215]

Feature gate: #![feature(pathbuf_into_string)]

This is a tracking issue for rust-lang/libs-team#307

Currently, to convert a PathBuf into a String, you had to first use PathBuf::into_os_string and then OsString::into_string. However, with this feature, you can convert a PathBuf directly into a String using PathBuf::into_string, allowing you to not need to write the intermediate PathBuf::into_os_string.

Public API

// use std::path::Pathbuf; 

impl PathBuf {
    pub fn into_string(self) -> Result<String, PathBuf> { ... }
}

Steps / History

(Remember to update the S-tracking-* label when checking boxes.)

• ACP: Add PathBuf::into_string (that mirrors OsString::into_string) libs-team#307
• Implementation: Implemented PathBuf::into_string #156204
• Final comment period (FCP)¹
• Stabilization PR: Stabilize PathBuf::into_string #156840

Unresolved Questions

• None yet.

Footnotes

1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩

[asder8215]

@rustbot label -S-tracking-unimplemented

[asder8215]

@nia-e Is it alright to make a stabilization PR on this tracking issue? This is a pretty uncontroversial change that I don't think there's much to question or to have doubts about here.

[WiSaGaN]

Do we already have stable items named into_sth but it may return Err? I thought we use try_ino_sth versus into_sth to distinguish that?

[asder8215]

See OsString::into_string. Even though the name of this function is into_string and not try_into_string, we can't truly create a guaranteed into implementation from a PathBuf to a String because it needs to contain valid Unicode data (since Rust's string needs to be valid UTF-8 encoded, and hence why we return the PathBuf itself if it contains invalid Unicode data).

To keep it consistent, with OsString::into_string, I would preferably keep the name PathBuf::into_string.

[Amanieu]

@rfcbot merge libs-api

[rust-rfcbot]

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @the8472

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.