Split up lint/builtin.rs

[kmcallister]

It's getting pretty big, and the code is very modular.

[huonw]

It would be neat to move as many of these into an external crate as possible, to enable faster iteration.

[richo]

It seems like this can be closed, unless I'm misinterpreting the issue to actually split each lint out into it's own crate.

[caipre]

@kmcallister / @huonw close?

[huonw]

Most lints are now defined in the librustc_lint crate, but they're all in one huge file. It would make sense to break that file up (e.g. an "obvious" division would be breaking out separate modules for the lint groups).

[richo]

I'm nominally interested in working on this (basically cc me)

On Sunday, May 10, 2015, Huon Wilson notifications@github.com wrote:

Most lints are now defined in the librustc_lint crate, but they're all in one
huge file
https://github.com/rust-lang/rust/blob/9ecc9896dedb426e3f4eb3d23dfc60192fe5275f/src/librustc_lint/builtin.rs.
It would make sense to break that file up (e.g. an "obvious" division would
be breaking out separate modules for the lint groups

rust/src/librustc_lint/lib.rs

Lines 122 to 128 in 9ecc989

	add_lint_group!(sess, "bad_style",
	NON_CAMEL_CASE_TYPES, NON_SNAKE_CASE, NON_UPPER_CASE_GLOBALS);
	add_lint_group!(sess, "unused",
	UNUSED_IMPORTS, UNUSED_VARIABLES, UNUSED_ASSIGNMENTS, DEAD_CODE,
	UNUSED_MUT, UNREACHABLE_CODE, UNUSED_MUST_USE,
	UNUSED_UNSAFE, PATH_STATEMENTS);

).

—
Reply to this email directly or view it on GitHub
#22206 (comment).

[caipre]

@richo: Were you claiming this? Otherwise I'll start on it.

[richo]

Nope, I wanted to make sure that emails wind up in the part of my inbox that I read, but I'm probably not planning to work on it soon. Feel free!