librustrt fails to link

[kud1ing]

I've experienced this recently in both master and incoming:

link: rt/x86_64-apple-darwin/librustrt.dylib
Undefined symbols for architecture x86_64:
  "_uv__fs_event_close", referenced from:
      _uv_close in libuv.a(core.o)
  "_uv__hrtime", referenced from:
      _uv_hrtime in libuv.a(core.o)
      _uv__update_time in libuv.a(core.o)
      _uv__loop_init in libuv.a(loop.o)
  "_uv__io_poll", referenced from:
      _uv_run in libuv.a(core.o)
  "_uv__platform_loop_delete", referenced from:
      _uv__loop_delete in libuv.a(loop.o)
  "_uv__platform_loop_init", referenced from:
      _uv__loop_init in libuv.a(loop.o)
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
make: *** [rt/x86_64-apple-darwin/librustrt.dylib] Error 1

That is from a clean clone on Mac OS X 10.8.

[kud1ing]

We currently use libuv from Feb 06, 2013. There are some more recent commits regarding Darwin build system. E.g. joyent/libuv@0761fb5 and joyent/libuv@62332ea

[kud1ing]

I think i compiled and linked libuv HEAD without success.

[bnoordhuis]

It looks like src/unix/darwin.c and src/unix/fsevents.c aren't linked in. I'll see if I can work up a patch tomorrow.

[bnoordhuis]

Sanity check: are you linking to the in-tree libuv copy or an external one?

[kud1ing]

I have not configured anything special, i assume Rust uses the in-tree libuv in any case.
I will check at home.

[bnoordhuis]

FWIW, I can't reproduce your issue. I just built master on a 64 bits 10.8.2 machine.

[kud1ing]

Thanks for trying.
This is starting to drive me crazy. I don't see what might have caused this for me.

[kud1ing]

libuv is indeed compiled in-tree and those symbols are indeed undefined:

~/Github/rust/build/rt/x86_64-apple-darwin/libuv$ nm libuv.a  | grep _uv__fs_event_close
                 U _uv__fs_event_close
~/Github/rust/build/rt/x86_64-apple-darwin/libuv$ nm libuv.a  | grep _uv__hrtime
                 U _uv__hrtime
                 U _uv__hrtime
...

[kud1ing]

The same happens when i clone libuv on its own:

git clone git://github.com/joyent/libuv.git
cd libuv/
make
nm libuv.a | grep _uv__fs_event_close
                 U _uv__fs_event_close
nm libuv.a | grep _uv__hrtime
                 U _uv__hrtime
                 U _uv__hrtime

The object files src/unix/darwin.o and src/unix/fsevents.o are indeed missing.

[kud1ing]

@bnoordhuis: I think i got it.

In libuv's config-unix.mk the variable $OS is compared for darwin.
On my system $OS is Darwin though.

[kud1ing]

The root cause is a bug in my ~/.profile. Closing, i am sorry.