resolve: Pre-compute non-reexport module children

[petrochenkov]

Instead of repeating the same logic by walking HIR during metadata encoding.

The only difference is that we are no longer encoding macro_rules items, but we never currently need them as a part of this list. They can be encoded separately if this need ever arises.

module_reexports is also un-querified, because I don't see any reasons to make it a query, only overhead.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[petrochenkov]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7f89194ea8ce4ab3b7a465d1caed926a489e8601 with merge ae0a3ff508bc3d46b096586d3b5848bd746e5c1c...

[bors]

☀️ Try build successful - checks-actions
Build commit: ae0a3ff508bc3d46b096586d3b5848bd746e5c1c (ae0a3ff508bc3d46b096586d3b5848bd746e5c1c)

[rust-timer]

Finished benchmarking commit (ae0a3ff508bc3d46b096586d3b5848bd746e5c1c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.4%, -0.3%]	19
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-1.4%, -0.3%]	19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.7%, 1.3%]	4
Regressions ❌ (secondary)	2.1%	[1.5%, 2.5%]	3
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-4.3%	[-7.1%, -1.5%]	2
All ❌✅ (primary)	0.7%	[-0.7%, 1.3%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.4%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.8%, -0.4%]	4

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[petrochenkov]

@rustbot ready

[cjgillot]

For Res::Err and ambiguities, should this closure just be a no-op?

[petrochenkov]

Yes, those are effectively imports that import nothing, at least from other crates' points of view.
(Although for ambiguities it's an open question - #36837.)

[petrochenkov]

@rustbot ready

[compiler-errors]

r? @cjgillot

[cjgillot]

@bors r+

[bors]

📌 Commit 7c40a6f has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7c40a6f with merge 7a78c4f...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 7a78c4f to master...

[rust-timer]

Finished benchmarking commit (7a78c4f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.5%, -0.2%]	26
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-0.8%	[-1.5%, -0.2%]	26

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.0%, 4.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.