Improve accessibility for source sidebar collapse/expand button - #119049
Closed
GuillaumeGomez wants to merge 3 commits into
Closed
Improve accessibility for source sidebar collapse/expand button#119049GuillaumeGomez wants to merge 3 commits into
GuillaumeGomez wants to merge 3 commits into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
Contributor
|
I think, if we're going to change the design this much, we might just redesign the control entirely. I'll have a PR open some time this week with a new version of the sidebar. |
Member
Author
|
Looking forward to it! :) |
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Dec 18, 2023
This is a redesign of the feature, with parts pulled from rust-lang#119049 but with a button that looks more like a button and matches the one used on other sidebar pages.
Contributor
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2023
…edesign, r=GuillaumeGomez rustdoc: clean up source sidebar hide button This is a redesign of the feature, with parts pulled from rust-lang#119049 but with a button that looks more like a button and matches the one used on other sidebar pages. Preview: * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/src/std/lib.rs.html * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/std/index.html | | Before | After | |--|--|--| | Closed |  |  | Open |  |  | Mobile Closed |  |  | Mobile Open |  | 
Collaborator
|
☔ The latest upstream changes (presumably #119066) made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions Bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 1, 2024
…r=GuillaumeGomez rustdoc: clean up source sidebar hide button This is a redesign of the feature, with parts pulled from rust-lang/rust#119049 but with a button that looks more like a button and matches the one used on other sidebar pages. Preview: * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/src/std/lib.rs.html * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/std/index.html | | Before | After | |--|--|--| | Closed |  |  | Open |  |  | Mobile Closed |  |  | Mobile Open |  | 
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
…r=GuillaumeGomez rustdoc: clean up source sidebar hide button This is a redesign of the feature, with parts pulled from rust-lang/rust#119049 but with a button that looks more like a button and matches the one used on other sidebar pages. Preview: * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/src/std/lib.rs.html * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/std/index.html | | Before | After | |--|--|--| | Closed |  |  | Open |  |  | Mobile Closed |  |  | Mobile Open |  | 
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
…r=GuillaumeGomez rustdoc: clean up source sidebar hide button This is a redesign of the feature, with parts pulled from rust-lang/rust#119049 but with a button that looks more like a button and matches the one used on other sidebar pages. Preview: * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/src/std/lib.rs.html * http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/std/index.html | | Before | After | |--|--|--| | Closed |  |  | Open |  |  | Mobile Closed |  |  | Mobile Open |  | 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two first commits come from #119016.
I thought it might be worth it improving source sidebar accessibility by adding
aria-labelon the buttons.r? @notriddle