Stop calling visitors V - #123211
Merged
Merged
Conversation
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
Contributor
|
r=me after parent lands |
Collaborator
|
☔ The latest upstream changes (presumably #123202) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
@bors r=estebank rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123189 (Log BOLT args in bootstrap `rustc` shim) - rust-lang#123211 (Stop calling visitors `V`) - rust-lang#123242 (pattern analysis: Require enum indices to be contiguous) - rust-lang#123260 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
Rollup merge of rust-lang#123211 - compiler-errors:V, r=estebank Stop calling visitors `V` Renames some visitors which currently have the unhelpful name of `V`. It's not self-documenting, and there is no situation where saving a few bytes in source code helps anyone. Stacked on top of rust-lang#123202 due to conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames some visitors which currently have the unhelpful name of
V. It's not self-documenting, and there is no situation where saving a few bytes in source code helps anyone.Stacked on top of #123202 due to conflict.