simd packed types: remove outdated comment, extend codegen test

[RalfJung]

It seems like #125311 made that check in codegen unnecessary?

r? @workingjubilee @calebzulawski

[calebzulawski]

Yep, that should never happen now
@bors r+

[bors]

📌 Commit 1bfbbf0 has been approved by calebzulawski

It is now in the queue for this repository.

[workingjubilee]

shouldn't it still be an immediate if it's not repr(packed)?

maybe here is a bad place to issue that check, but

[RalfJung]

It should always be an immediate.

I can turn it into an assert, if that's what you mean?

[workingjubilee]

Oh! I think I misparsed what you initially said.

Yeah, an assert! or debug_assert! sounds reasonable, though not strictly necessary, as noted.

[RalfJung]

All right, did that.

@bors r=calebzulawski,workingjubilee

[bors]

📌 Commit 2f2031d has been approved by calebzulawski,workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2f2031d with merge 0bab061...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

c438b865cc81: Pushed
0b9c994b0484: Pushed
5c6894467d12: Pushed
7e150558cf11: Pushed
Put "https://ghcr.io/v2/rust-lang-ci/rust-ci/manifests/9b7a697e64f469f5512dfaf34c1674d69ace7ff101833be85272d223d5506be0ed9a4fddb9ef40696aecd8142b0b6792811934eca96004c5d16ff761f5426666": EOF
##[error]Process completed with exit code 1.

[bors]

💔 Test failed - checks-actions

[RalfJung]

@bors retry Put "https://ghcr.io/v2/rust-lang-ci/rust-ci/manifests/9b7a697e64f469f5512dfaf34c1674d69ace7ff101833be85272d223d5506be0ed9a4fddb9ef40696aecd8142b0b6792811934eca96004c5d16ff761f5426666": EOF

[bors]

⌛ Testing commit 2f2031d with merge b3ca6ee...

[bors]

☀️ Test successful - checks-actions
Approved by: calebzulawski,workingjubilee
Pushing b3ca6ee to master...

[rust-timer]

Finished benchmarking commit (b3ca6ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 1.6%, secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.0%, 3.1%]	4
Regressions ❌ (secondary)	3.7%	[1.3%, 6.2%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[1.0%, 3.1%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 319.75 MiB -> 319.12 MiB (-0.20%)