Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake - #127328

Oneirical · 2024-07-04T17:49:26Z

Part of #121876 and the associated Google Summer of Code project.

Please test on i686-msvc. Expected to fail.

try-job: aarch64-apple

rustbot · 2024-07-04T17:49:33Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-04T17:49:35Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-04T17:51:16Z

@bors delegate+ (for try jobs only)

bors · 2024-07-04T17:51:19Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-07-04T18:58:13Z

@bors try

bors · 2024-07-04T18:59:23Z

⌛ Trying commit 85aaaee with merge 7a10070...

Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: i686-msvc

bors · 2024-07-04T20:47:15Z

💔 Test failed - checks-actions

Oneirical · 2024-07-05T15:14:51Z

@bors try

bors · 2024-07-05T15:16:00Z

⌛ Trying commit 85aaaee with merge bd19fc2...

Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: aarch64-apple

bors · 2024-07-05T16:23:53Z

💔 Test failed - checks-actions

Oneirical · 2024-07-05T16:47:59Z

@rustbot review
Ignore statement restored and reason added. Previous normal CI was green.

jieyouxu

Thanks!

jieyouxu · 2024-07-06T05:15:24Z

@bors r+ rollup=iffy

jieyouxu · 2024-07-06T05:17:24Z

@bors r+ rollup=iffy

bors · 2024-07-06T05:17:27Z

📌 Commit 9f994b6 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-07-06T09:35:46Z

⌛ Testing commit 9f994b6 with merge b6494f0...

…eyouxu Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: aarch64-apple

rust-log-analyzer · 2024-07-06T10:41:00Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-07-06T10:41:36Z

💔 Test failed - checks-actions

jieyouxu · 2024-07-06T14:45:17Z

@bors r-

Oneirical · 2024-07-08T16:04:08Z

That does not seem related to this PR at all:

[RUSTC-TIMING] cargo test:false 18.221
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe`

Caused by:
  Access is denied. (os error 5)

Could it be spurious? Would it be worthwhile to try again without changes? @rustbot review

jieyouxu · 2024-07-08T16:06:31Z

We've been having spurious perm issues on windows, it's not ur changes, u can try again

jieyouxu · 2024-07-08T16:07:21Z

@bors r+

bors · 2024-07-08T16:07:23Z

📌 Commit 9f994b6 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-07-08T23:07:55Z

⌛ Testing commit 9f994b6 with merge d4a6200...

bors · 2024-07-09T01:23:12Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing d4a6200 to master...

rust-timer · 2024-07-09T08:02:49Z

Finished benchmarking commit (d4a6200): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[2.4%, 8.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 701.545s -> 705.089s (0.51%)
Artifact size: 328.62 MiB -> 328.77 MiB (0.04%)

Oneirical added 2 commits July 4, 2024 12:48

rewrite pass-linker-flags to rmake

f11ab15

rewrite pass-linker-flags-flavor to rmake

bc76592

rustbot assigned jieyouxu Jul 4, 2024

jieyouxu mentioned this pull request Jul 4, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024

This comment has been minimized.

Sign in to view

rewrite pass-linker-flags-from-dep to rmake

9f994b6

Oneirical force-pushed the yield-to-petestrians branch from 85aaaee to 9f994b6 Compare July 5, 2024 16:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2024

jieyouxu approved these changes Jul 6, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 8, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 9, 2024

bors merged commit d4a6200 into rust-lang:master Jul 9, 2024

rustbot added this to the 1.81.0 milestone Jul 9, 2024

Uh oh!

Uh oh!

Conversation

Oneirical commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 4, 2024

Uh oh!

rustbot commented Jul 4, 2024

Uh oh!

jieyouxu commented Jul 4, 2024

Uh oh!

bors commented Jul 4, 2024

Uh oh!

Oneirical commented Jul 4, 2024

Uh oh!

bors commented Jul 4, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 4, 2024

Uh oh!

Oneirical commented Jul 5, 2024

Uh oh!

bors commented Jul 5, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 5, 2024

Uh oh!

Oneirical commented Jul 5, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 6, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

jieyouxu commented Jul 6, 2024

Uh oh!

bors commented Jul 6, 2024

Uh oh!

bors commented Jul 6, 2024

Uh oh!

rust-log-analyzer commented Jul 6, 2024

Uh oh!

bors commented Jul 6, 2024

Uh oh!

jieyouxu commented Jul 6, 2024

Uh oh!

Oneirical commented Jul 8, 2024

Uh oh!

jieyouxu commented Jul 8, 2024

Uh oh!

jieyouxu commented Jul 8, 2024

Uh oh!

bors commented Jul 8, 2024

Uh oh!

bors commented Jul 8, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

rust-timer commented Jul 9, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Oneirical commented Jul 4, 2024 •

edited

Loading