Skip to content

uefi: process: Add args support - #129838

Merged
bors merged 1 commit into
rust-lang:masterfrom
Ayush1325:uefi-process-args
Nov 21, 2024
Merged

uefi: process: Add args support#129838
bors merged 1 commit into
rust-lang:masterfrom
Ayush1325:uefi-process-args

Conversation

@Ayush1325

Copy link
Copy Markdown
Contributor

r​? joboet

@rustbot

rustbot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2024
@Ayush1325

Copy link
Copy Markdown
Contributor Author

r? @joboet

@rustbot

rustbot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

Could not assign reviewer from: joboet.
User(s) joboet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@Ayush1325

Copy link
Copy Markdown
Contributor Author

Well, any new reviewer might want to look at: #123196 for more context about uefi process.

@Ayush1325
Ayush1325 force-pushed the uefi-process-args branch 2 times, most recently from 955ec4c to ab840e0 Compare September 1, 2024 20:37
@Ayush1325

Copy link
Copy Markdown
Contributor Author

ping @Amanieu

Comment thread library/std/src/sys/pal/uefi/process.rs Outdated
Comment thread library/std/src/sys/pal/uefi/process.rs Outdated
Comment thread library/std/src/sys/pal/uefi/process.rs Outdated
Comment thread library/std/src/sys/pal/uefi/process.rs Outdated
- Wrap all args with quotes.
- Escape ^ and " inside quotes using ^.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Ayush1325 requested a review from joboet October 11, 2024 04:38
@Amanieu

Amanieu commented Nov 20, 2024

Copy link
Copy Markdown
Member

r? @joboet

@rustbot rustbot assigned joboet and unassigned Amanieu Nov 20, 2024
@joboet

joboet commented Nov 20, 2024

Copy link
Copy Markdown
Member

Looks good!
@bors r+

@joboet

joboet commented Nov 20, 2024

Copy link
Copy Markdown
Member

bors is asleep again, hang on

@joboet joboet closed this Nov 20, 2024
@joboet joboet reopened this Nov 20, 2024
@joboet

joboet commented Nov 20, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 3727a8c has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@bors
bors merged commit 0576cc9 into rust-lang:master Nov 21, 2024
@rustbot rustbot added this to the 1.84.0 milestone Nov 21, 2024
@Ayush1325
Ayush1325 deleted the uefi-process-args branch November 21, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants