Skip to content

[cfg_match] Document the use of expressions. - #135625

Merged
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:cfg-match-foo-bar-baz
Jan 29, 2025
Merged

[cfg_match] Document the use of expressions.#135625
bors merged 1 commit into
rust-lang:masterfrom
c410-f3r:cfg-match-foo-bar-baz

Conversation

@c410-f3r

@c410-f3r c410-f3r commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

cc #115585

Adds documentation to this new feature introduced in #133720.

@rustbot

rustbot commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 17, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss

ehuss commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Can you remove all of the submodule updates?

@c410-f3r
c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 90608ee to 5844eac Compare January 17, 2025 15:30
@c410-f3r

c410-f3r commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

r? T-libs

@rustbot rustbot assigned tgross35 and jhpratt and unassigned joboet and tgross35 Jan 21, 2025
tgross35
tgross35 reviewed Jan 21, 2025
View reviewed changes
Comment thread library/core/src/macros/mod.rs Outdated
/// }
/// ```
///
/// If desired, it is possible to return expressions through the use of surrounding braces.

@tgross35 tgross35 Jan 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// If desired, it is possible to return expressions through the use of surrounding braces.
/// If desired, it is possible to return expressions through the use of surrounding braces:

Nit, colon to introduce an example

@tgross35

tgross35 commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

One nit and squash please, then r=me

@c410-f3r
c410-f3r force-pushed the cfg-match-foo-bar-baz branch from 5844eac to 587b9c6 Compare January 21, 2025 11:45
@jhpratt

jhpratt commented Jan 21, 2025

Copy link
Copy Markdown
Member

@bors r=tgross35,jhpratt rollup

@bors

bors commented Jan 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 587b9c6 has been approved by tgross35,jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 21, 2025
@jieyouxu
Rollup merge of rust-lang#135625 - c410-f3r:cfg-match-foo-bar-baz, r=…
f99cae1 
…tgross35,jhpratt

[cfg_match] Document the use of expressions.

cc rust-lang#115585

Adds documentation to this new feature introduced in rust-lang#133720.
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 21, 2025
@jieyouxu
Rollup merge of rust-lang#135625 - c410-f3r:cfg-match-foo-bar-baz, r=…
b4e2fb5 
…tgross35,jhpratt

[cfg_match] Document the use of expressions.

cc rust-lang#115585

Adds documentation to this new feature introduced in rust-lang#133720.
@jieyouxu jieyouxu mentioned this pull request Jan 21, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
@bors
Auto merge of rust-lang#135825 - jieyouxu:rollup-bske4m7, r=jieyouxu
dfd5d41 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4)
 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135638 (Make it possible to build GCC on CI)
 - rust-lang#135648 (support wasm inline assembly in `naked_asm!`)
 - rust-lang#135707 (Shorten linker output even more when `--verbose` is not present)
 - rust-lang#135750 (Add an example of using `carrying_mul_add` to write wider multiplication)
 - rust-lang#135779 (CI: free disk on linux arm runner)
 - rust-lang#135793 (Ignore `mermaid.min.js`)
 - rust-lang#135810 (Add Kobzol on vacation)
 - rust-lang#135814 (ci: use ghcr buildkit image)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#135625 - c410-f3r:cfg-match-foo-bar-baz, r=…
0e31bd4 
…tgross35,jhpratt

[cfg_match] Document the use of expressions.

cc rust-lang#115585

Adds documentation to this new feature introduced in rust-lang#133720.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 21, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2025
@bors
Auto merge of rust-lang#135835 - matthiaskrgr:rollup-pzaa7cn, r=matth…
f77ead0 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#132232 (CI: build FreeBSD artifacts on FreeBSD 13.4)
 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135750 (Add an example of using `carrying_mul_add` to write wider multiplication)
 - rust-lang#135793 (Ignore `mermaid.min.js`)
 - rust-lang#135810 (Add Kobzol on vacation)
 - rust-lang#135816 (Use `structurally_normalize` instead of manual `normalizes-to` goals in alias relate errors)
 - rust-lang#135821 (fix OsString::from_encoded_bytes_unchecked description)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr

matthiaskrgr commented Jan 21, 2025

Copy link
Copy Markdown
Member

@bors r-
#135835 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2025
@rustbot rustbot assigned tgross35 and Noratrieb and unassigned jhpratt, joboet and tgross35 Jan 28, 2025
@tgross35

tgross35 commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

@bors r=tgross35,jhpratt

Do we know why it choked on the comma?

The macro does not support trailing commas at the current time.

Why was this not a problem during PR CI though?

@bors

bors commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7d9fe91 has been approved by tgross35,jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 29, 2025
@Zalathar
Rollup merge of rust-lang#135625 - c410-f3r:cfg-match-foo-bar-baz, r=…
5317161 
…tgross35,jhpratt

[cfg_match] Document the use of expressions.

cc rust-lang#115585

Adds documentation to this new feature introduced in rust-lang#133720.
@Zalathar Zalathar mentioned this pull request Jan 29, 2025
Closed
@fmease fmease mentioned this pull request Jan 29, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@bors
Auto merge of rust-lang#136225 - fmease:rollup-fm7m744, r=fmease
ccc9ba5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#135625 ([cfg_match] Document the use of expressions.)
 - rust-lang#135902 (Do not consider child bound assumptions for rigid alias)
 - rust-lang#135943 (Rename `Piece::String` to `Piece::Lit`)
 - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
 - rust-lang#136143 (Update books)
 - rust-lang#136147 (ABI-required target features: warn when they are missing in base CPU)
 - rust-lang#136164 (Refactor FnKind variant to hold &Fn)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 53f343f into rust-lang:master Jan 29, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
@madsmtm madsmtm mentioned this pull request Feb 17, 2025
Closed
5 tasks
@jieyouxu jieyouxu added the F-cfg_select `#![feature(cfg_select)]` label Aug 14, 2025
@folkertdev folkertdev mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 left review comments

Assignees

@Noratrieb Noratrieb

Labels

F-cfg_select `#![feature(cfg_select)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.