Skip to content

Suggest Vec<T> instead of [T] - #159520

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bb1yd:fix-159491
Jul 31, 2026
Merged

Suggest Vec<T> instead of [T]#159520
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bb1yd:fix-159491

Conversation

@bb1yd

@bb1yd bb1yd commented Jul 18, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #159491

Looks like a regression introduced by:#151530

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 74 candidates
  • Random selection from 16 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang

chenyukang commented Jul 18, 2026

Copy link
Copy Markdown
Member

please use proper git commit log.

@folkertdev

folkertdev commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jul 19, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@bb1yd

bb1yd commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Renamed the git commit
@rustbot ready

Also sorry for the noise, I was confused by git.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2026
folkertdev
folkertdev requested changes Jul 19, 2026
View reviewed changes
Comment thread tests/ui/resolve/suggestions/suggest-vec-not-slice.rs Outdated
Comment thread tests/ui/resolve/suggestions/suggest-vec-not-slice.rs
Comment thread compiler/rustc_resolve/src/late/diagnostics.rs Outdated
Comment thread compiler/rustc_resolve/src/late/diagnostics.rs
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2026
@bb1yd

bb1yd commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2026
@bb1yd
bb1yd requested a review from folkertdev July 31, 2026 12:52
folkertdev
folkertdev approved these changes Jul 31, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2ee8bbb has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159520 - bb1yd:fix-159491, r=folkertdev
900752b 
Suggest `Vec<T>` instead of `[T]`

Fixes rust-lang#159491

Looks like a regression introduced by:rust-lang#151530
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 31, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of #160283 - JonathanBrouwer:rollup-DJjXn4s, r=JonathanBro…
71a03d3 
…uwer

Rollup of 21 pull requests

Successful merges:

 - #160100 (Add "system" option to `override-allocator` directive)
 - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
 - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
 - #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
 - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
 - #154202 (rustfmt: Format `cfg_select!`)
 - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
 - #159520 (Suggest `Vec<T>` instead of `[T]`)
 - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
 - #160066 (rustc_middle: lint attribute cleanups)
 - #160085 (Remove various superfluous lint attributes)
 - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
 - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
 - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
 - #160157 (Remove outdated comments from `va_list.rs`)
 - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
 - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
 - #160244 (Rename splat to rustc_splat in error messages)
 - #160246 (dont fire `unused_mut` on `&pin mut self`)
 - #160247 (Configure backport nominations for rustfmt)
 - #160274 (renovate: update lock files weekly)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 31, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
ad3d0bc 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #160100 (Add "system" option to `override-allocator` directive)
 - #160220 (Refactor: shrink region ext traits)
 - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
 - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
 - #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
 - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
 - #154202 (rustfmt: Format `cfg_select!`)
 - #159520 (Suggest `Vec<T>` instead of `[T]`)
 - #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
 - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
 - #160066 (rustc_middle: lint attribute cleanups)
 - #160085 (Remove various superfluous lint attributes)
 - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
 - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
 - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
 - #160157 (Remove outdated comments from `va_list.rs`)
 - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
 - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
 - #160244 (Rename splat to rustc_splat in error messages)
 - #160246 (dont fire `unused_mut` on `&pin mut self`)
 - #160247 (Configure backport nominations for rustfmt)
 - #160274 (renovate: update lock files weekly)
@scottmcm

scottmcm commented Jul 31, 2026

Copy link
Copy Markdown
Member

Thanks for re-fixing #76007 :)

@rust-bors
rust-bors Bot merged commit 57f2f41 into rust-lang:main Jul 31, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 31, 2026
rust-timer added a commit that referenced this pull request Jul 31, 2026
@rust-timer
Unrolled build for #159520
766c7a0 
Rollup merge of #159520 - bb1yd:fix-159491, r=folkertdev

Suggest `Vec<T>` instead of `[T]`

Fixes #159491

Looks like a regression introduced by:#151530
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
531cd3b 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
 - rust-lang/rust#160220 (Refactor: shrink region ext traits)
 - rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
 - rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
 - rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
 - rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
 - rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
 - rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
 - rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
 - rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
 - rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
 - rust-lang/rust#160085 (Remove various superfluous lint attributes)
 - rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
 - rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
 - rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
 - rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
 - rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
 - rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
 - rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
 - rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
 - rust-lang/rust#160247 (Configure backport nominations for rustfmt)
 - rust-lang/rust#160274 (renovate: update lock files weekly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees

@folkertdev folkertdev

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

Invalid suggestion of -> [u8]

6 participants

@bb1yd @rustbot @rust-log-analyzer @chenyukang @folkertdev @scottmcm