Suggest `cast_signed()` for overflowing signed integer literals - #160420

YingqiDuan · 2026-08-03T08:20:30Z

This PR uses cast_signed() for same-width conversions and keeps as for different-width conversions.

It also updates the affected UI test snapshots.

rustbot · 2026-08-03T08:20:36Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @mu001999 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 20 candidates

mu001999

@rustbot author

View changes since this review

rustbot · 2026-08-04T12:32:02Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

YingqiDuan · 2026-08-05T00:00:23Z

@rustbot ready

mu001999 · 2026-08-05T04:30:57Z

@rustbot author

YingqiDuan · 2026-08-05T04:43:29Z

@rustbot ready

mu001999 · 2026-08-05T05:26:42Z

Could you squash the commits? Then I will approve this :)

YingqiDuan · 2026-08-05T05:31:02Z

@bors squash msg="Suggest cast_signed for overflowing integer literals"

Co-authored-by: Roland Xu <rcu@live.com>

rust-bors · 2026-08-05T05:31:24Z

🔨 4 commits were squashed into eace512.

YingqiDuan · 2026-08-05T05:32:27Z

Squashed, thanks!

mu001999

Thanks!

@bors r+ rollup

View changes since this review

rust-bors · 2026-08-05T05:34:23Z

📌 Commit eace512 has been approved by mu001999

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

…suggestion, r=mu001999 Suggest `cast_signed()` for overflowing signed integer literals This PR uses `cast_signed()` for same-width conversions and keeps `as` for different-width conversions. It also updates the affected UI test snapshots. Fixes rust-lang#160403

…uwer Rollup of 22 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #159784 (Hint that memchr returns an in-bounds index) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…suggestion, r=mu001999 Suggest `cast_signed()` for overflowing signed integer literals This PR uses `cast_signed()` for same-width conversions and keeps `as` for different-width conversions. It also updates the affected UI test snapshots. Fixes rust-lang#160403

…uwer Rollup of 25 pull requests Successful merges: - #154585 (treat no_mangle_generic_items as hard error instead of lint warning) - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…uwer Rollup of 25 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe by unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160501 (Add bootstrap CLI snapshot test for testing miri) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

Rollup merge of #160420 - YingqiDuan:fix-160403-cast-signed-suggestion, r=mu001999 Suggest `cast_signed()` for overflowing signed integer literals This PR uses `cast_signed()` for same-width conversions and keeps `as` for different-width conversions. It also updates the affected UI test snapshots. Fixes #160403

rustbot assigned mu001999 Aug 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026

mu001999 reviewed Aug 4, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/lints.rs Outdated

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 4, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2026

mu001999 reviewed Aug 5, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/types/literal.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2026

This comment has been minimized.

Sign in to view

Suggest cast_signed for overflowing integer literals

eace512

Co-authored-by: Roland Xu <rcu@live.com>

rust-bors Bot force-pushed the fix-160403-cast-signed-suggestion branch from ac46df1 to eace512 Compare August 5, 2026 05:31

mu001999 approved these changes Aug 5, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2026

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 11 pull requests #160547

Closed

jhpratt mentioned this pull request Aug 5, 2026

Rollup of 16 pull requests #160549

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 22 pull requests #160554

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160557

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160559

Merged

rust-bors Bot merged commit 7afe2e1 into rust-lang:main Aug 5, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 5, 2026

Uh oh!

Uh oh!

Conversation

YingqiDuan commented Aug 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 3, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Aug 4, 2026

Uh oh!

YingqiDuan commented Aug 5, 2026

Uh oh!

Uh oh!

mu001999 commented Aug 5, 2026

Uh oh!

YingqiDuan commented Aug 5, 2026

Uh oh!

mu001999 commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YingqiDuan commented Aug 5, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 5, 2026

Uh oh!

YingqiDuan commented Aug 5, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YingqiDuan commented Aug 3, 2026 •

edited by rustbot

Loading

mu001999 left a comment •

edited by rustbot

Loading

mu001999 commented Aug 5, 2026 •

edited

Loading

mu001999 left a comment •

edited by rustbot

Loading