Skip to content

Avoid the std DLL copy alongside rustc - #160600

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Zoxc:no-extra-std-dll
Aug 6, 2026
Merged

Avoid the std DLL copy alongside rustc#160600
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Zoxc:no-extra-std-dll

Conversation

@Zoxc

@Zoxc Zoxc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This removes the extra the std DLL copy alongside rustc. Fixes #131587.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 6, 2026
@Zoxc

Zoxc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
Avoid the std DLL copy alongside rustc

try-job: dist-x86_64-msvc
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f488611 (f488611cbf123ddd85a7b443df8a99e85f053e1c)
Base parent: f73951d (f73951df0a5566d94d13b7954acd9f4ab1fa3734)

@Zoxc

Zoxc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

It looks like #131587 may be fixed. Maybe we should retry this? cc @Kobzol

@Kobzol

Kobzol commented Aug 6, 2026

Copy link
Copy Markdown
Member

Since tests pass, I'm fine with that.

@Kobzol

Kobzol commented Aug 6, 2026

Copy link
Copy Markdown
Member

Feel free to r=me. Btw I just noticed that we ship .pdb files there (at least in the rustc-nightly archive). Interesting.

@Zoxc
Zoxc marked this pull request as ready for review August 6, 2026 07:32
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 6, 2026
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789

@Zoxc

Zoxc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

We want PDB files to get function names for backtraces. They wouldn't need to be full debug info though.

@Kobzol

Kobzol commented Aug 6, 2026

Copy link
Copy Markdown
Member

The files are rather large, so if we can somehow make them smaller, that would be great. But that's for a separate PR.

Let's see what happens on nightly.

@bors r+

r? kobzol

@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f207c16 has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
Avoid the std DLL copy alongside rustc

This removes the extra the std DLL copy alongside rustc. Fixes rust-lang#131587.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
Avoid the std DLL copy alongside rustc

This removes the extra the std DLL copy alongside rustc. Fixes rust-lang#131587.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 6, 2026
Avoid the std DLL copy alongside rustc

This removes the extra the std DLL copy alongside rustc. Fixes rust-lang#131587.
rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
…uwer

Rollup of 17 pull requests

Successful merges:

 - #159530 (Cap socket send length to c_int::MAX on Apple targets)
 - #159506 (Allow associated const equality constraints with GCA)
 - #160006 (Account for desugaring in method call move errors)
 - #160415 (Split `aarch64-apple{,-macos-26}` => `aarch64-apple{,-macos-26}-{1,2}` jobs)
 - #160464 (fix: Check the fallback map before queueing child in `visible_parent_map` breadth-first search)
 - #160555 (Split `apply_primary_terminator_effect`)
 - #160592 (Suggest if-let chain continuation on unclosed delimiter)
 - #160600 (Avoid the std DLL copy alongside rustc)
 - #160156 (check_consts: exhaustively match on CastKind)
 - #160211 (Rename `#[unroll]` => `#[rustc_unroll]` to mitigate nameres ambiguity)
 - #160304 (Add tests for fixed new solver issues)
 - #160398 (rustc_abi: Add `LayoutData::is_variant_uninhabited` method)
 - #160546 (Update error message in documentation comments)
 - #160568 (Use `VisitorResult` helper macros)
 - #160571 (Add regression test for array type recovery in generic arguments)
 - #160588 (add a test showing polonius alpha is not a subset of datalog polonius)
 - #160617 (Add a suggestion to MissingUnsafeOnExtern diagnostic)
@rust-bors
rust-bors Bot merged commit f34343d into rust-lang:main Aug 6, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 6, 2026
rust-timer added a commit that referenced this pull request Aug 6, 2026
Rollup merge of #160600 - Zoxc:no-extra-std-dll, r=Kobzol

Avoid the std DLL copy alongside rustc

This removes the extra the std DLL copy alongside rustc. Fixes #131587.
@Zoxc
Zoxc deleted the no-extra-std-dll branch August 6, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove std.dll from dist archives on Windows

4 participants