Always statically link std into rustc_driver - #160622
Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Always statically link std into rustc_driver try-job: dist-x86_64-mingw
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
d869a4a to
55dd1f6
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
cc @Kobzol Another bootstrap cleanup |
| @@ -2351,12 +2351,7 @@ impl CommandLineStep for Assemble { | |||
|
|
|||
| // If we link statically to stdlib, do not copy the libstd dynamic library file | |||
55dd1f6 to
efcf0fa
Compare
This comment has been minimized.
This comment has been minimized.
Always statically link std into rustc_driver try-job: dist-x86_64-mingw
|
@bors try jobs=dist-x86_64-linux-quick |
This comment has been minimized.
This comment has been minimized.
Always statically link std into rustc_driver try-job: dist-x86_64-linux-quick
|
@rust-timer build 268c2a8 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (268c2a8): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.4%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 460.09s -> 459.457s (-0.14%) |
This always statically links std into rustc_driver by removing the MinGW exception.
try-job: dist-x86_64-mingw