Skip to content

overflow -> ambig: trigger recursion_depth_exceeding_limit - #160632

Open
lcnr wants to merge 1 commit into
rust-lang:mainfrom
lcnr:overflow-to-ambig
Open

overflow -> ambig: trigger recursion_depth_exceeding_limit#160632
lcnr wants to merge 1 commit into
rust-lang:mainfrom
lcnr:overflow-to-ambig

Conversation

@lcnr

@lcnr lcnr commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

cc https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/overflow.20hard.20error.20.60calimero-store.60/with/614961692

the fact that this lint triggers multiple times for the same goal is pretty bad. We should somehow change this to only be emitted once per obligation or maybe even less. Looking at crates which trigger this lint, they sometimes emit it thousands of times. That seems pretty bad from a UX perspective.

r? @adwinwhite

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 6, 2026
@lcnr

lcnr commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 6, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 6, 2026
overflow -> ambig: trigger `recursion_depth_exceeding_limit`
@rust-log-analyzer

This comment has been minimized.

@lcnr
lcnr force-pushed the overflow-to-ambig branch from 9dcb449 to 940cc6c Compare August 6, 2026 11:51
@rust-bors

rust-bors Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f81a509 (f81a509f84288e35b6be72a05dee373179700839)
Base parent: 887804d (887804d5686c3bf9a090b5bbc23e3dcdfd9e316a)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f81a509): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.6%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-6.4% [-6.4%, -6.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.1% [-6.4%, 2.2%] 2

Cycles

Results (primary 2.2%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.1%, -0.0%] 19
Improvements ✅
(secondary)
-0.0% [-0.1%, -0.0%] 5
All ❌✅ (primary) -0.0% [-0.1%, -0.0%] 19

Bootstrap: 458.35s -> 466.079s (1.69%)
Artifact size: 398.64 MiB -> 398.58 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 6, 2026
@adwinwhite

adwinwhite commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Similar to #160254, the current perf collection won't be affected by this as they don't overflow(maybe except typenum)?

@adwinwhite

Copy link
Copy Markdown
Contributor

Should this be blocked on UX improvement? Or just land this fix first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants