[beta] backports - #160714

cuviper · 2026-08-07T17:03:41Z

rustfmt: Discover modules via cfg_select! rustfmt: Discover modules via cfg_select! #158372
Rename splat to avoid stable name collisions Rename splat to avoid stable name collisions #159817
Rename #[unroll] => #[rustc_unroll] to mitigate nameres ambiguity Rename #[unroll] => #[rustc_unroll] to mitigate nameres ambiguity #160211
[beta-1.98] Update cargo submodule [beta-1.98] Update cargo submodule #160596

r? me

(cherry picked from commit facc787)

(cherry picked from commit cb797b8)

fastmod --fixed-strings '#[splat]' '#[rustc_splat]' fastmod --fixed-strings '`splat` attribute' '`rustc_splat` attribute' fastmod --fixed-strings '$splat$' '$rustc_splat$' fastmod 'v0(.*)#\[rustc_splat\]' 'v0${1}#[splat]' tests/ui/splat/splat-mangling.rs (cherry picked from commit e574edf)

(cherry picked from commit bc1bb27)

Mitigation for [RUST-159429]. The recurring problem is that built-in attributes are treated differently compared to ordinary prelude attributes, built-in attributes, even while unstable, can name-collide with stable macro re-exports of the same name (and proc-macro helper attributes of the same name), which can break stable code. See [RUST-134964]. [RUST-159429]: rust-lang#159429 [RUST-134963]: rust-lang#134963 (cherry picked from commit 0a0f6df)

(cherry picked from commit 44d291e)

To account for the renamed `#[rustc_unroll]` attribute. (cherry picked from commit 91ee1f3)

This stderr diff is a funny side-effect of renaming `#[unroll]` => `#[rustc_unroll]`, where the `#[rustc_unknown]` attribute name is just similar enough edit distance wise to `#[rustc_unroll]` that `#[rustc_unroll]` shows up as a plausible suggestion candidate, lol. (cherry picked from commit 945d2f3)

(cherry picked from commit d1265b7)

rustbot · 2026-08-07T18:06:24Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

cuviper · 2026-08-07T18:07:16Z

@bors r+ rollup=never p=1

rust-bors · 2026-08-07T18:07:20Z

📌 Commit ebcacaa has been approved by cuviper

It is now in the queue for this repository.

[beta] backports - rustfmt: Discover modules via `cfg_select!` #158372 - Rename splat to avoid stable name collisions #159817 - Rename `#[unroll]` => `#[rustc_unroll]` to mitigate nameres ambiguity #160211 - [beta-1.98] Update cargo submodule #160596 r? me

rust-log-analyzer · 2026-08-07T22:40:58Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-08-07T22:41:21Z

💔 Test for 8ba9fdd failed: CI. Failed job:

auto - dist-powerpc64-linux-musl (web logs, enhanced plaintext logs)

[beta] backports - rustfmt: Discover modules via `cfg_select!` #158372 - Rename splat to avoid stable name collisions #159817 - Rename `#[unroll]` => `#[rustc_unroll]` to mitigate nameres ambiguity #160211 - [beta-1.98] Update cargo submodule #160596 r? me

rust-log-analyzer · 2026-08-09T01:07:47Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[01:22] / 
[EXTRA]    Verifying SHA256 checksum for 'ncurses-6.5.tar.gz'
#18 82.55 
[01:22] / 
[ERROR]    Bad sha256 digest for ncurses-6.5.tar.gz: 8c8c19abf9a1c325bccf4e9d9d520dfa4d54f590566e04aebc09382fbd4713b9, expect 136d91bc269a9a5785e5f9e980bc76ab57428f604ce3e5a5a90cebc767971cc6
#18 82.55 
[01:22] / 
[ERROR]    Digest verification failed; removing the download
#18 82.55 
[01:22] /

rust-bors · 2026-08-09T01:08:12Z

💔 Test for cda58a0 failed: CI. Failed job:

auto - dist-loongarch64-linux (web logs, enhanced plaintext logs)

jieyouxu · 2026-08-09T05:03:57Z

Bad sha256 digest for ncurses-6.5.tar.gz: 7a98c4ac3ea276a8da4500556171b6dee8ad4f0d30b211f1b79c42a23f628006, expect 136d91bc269a9a5785e5f9e980bc76ab57428f604ce3e5a5a90cebc767971cc6

I'll mirror ncurses, then this backport can ~~cherry pick that PR~~, actually, since it's CT-NG looking in ci-mirrors there's no r-l/r side changes needed.

theemathas · 2026-08-09T05:07:36Z

Why does the ncurses download give different SHA256 values each time?

In https://triage.rust-lang.org/gha-logs/rust-lang/rust/93177803816, it's 7a98c4ac3ea276a8da4500556171b6dee8ad4f0d30b211f1b79c42a23f628006

In https://triage.rust-lang.org/gha-logs/rust-lang/rust/93013015396, it's 8c5780bef692c331729f257866b0dd1ed4681fc4b2b65993c4c9a5099b2e8054

jieyouxu · 2026-08-09T05:28:09Z

CT-NG 1.28.0 ncurses 6.5 known good hashes:

https://github.com/crosstool-ng/crosstool-ng/blob/d427a7ca41690f9d50c04049df6b9b1fe35810d7/packages/ncurses/6.5/chksum#L1-L4

md5 ncurses-6.5.tar.gz ac2d2629296f04c8537ca706b6977687
sha1 ncurses-6.5.tar.gz cde3024ac3f9ef21eaed6f001476ea8fffcaa381
sha256 ncurses-6.5.tar.gz 136d91bc269a9a5785e5f9e980bc76ab57428f604ce3e5a5a90cebc767971cc6
sha512 ncurses-6.5.tar.gz fc5a13409d2a530a1325776dcce3a99127ddc2c03999cfeb0065d0eee2d68456274fb1c7b3cc99c1937bc657d0e7fca97016e147f93c7821b5a4a6837db821e8

Very strange. Checking GNU ncurses 6.5 (https://ftp.gnu.org/gnu/ncurses/), SHA256 is indeed

136d91bc269a9a5785e5f9e980bc76ab57428f604ce3e5a5a90cebc767971cc6

jieyouxu · 2026-08-09T05:34:49Z

Why does the ncurses download give different SHA256 values each time?

~~Perhaps two different ncurses are being looked for? These come from two different dist jobs.~~ No, it's both ncurses 6.5. It might be somehow coming from two different external mirrors...? Unless the GNU mirror is... returning slightly different artifacts non-deterministically?!

jieyouxu · 2026-08-09T06:24:39Z

ci-mirrors PR: rust-lang/ci-mirrors#54

jieyouxu · 2026-08-09T06:36:17Z

Let's try again...
@bors retry

jieyouxu · 2026-08-09T06:37:44Z

@bors try jobs=dist-powerpc64-linux-musl,dist-loongarch64-linux

[beta] backports try-job: dist-powerpc64-linux-musl try-job: dist-loongarch64-linux

rust-bors · 2026-08-09T09:10:27Z

☀️ Try build successful (CI)
Build commit: 5fe2984 (5fe29844001a77d2b776fd572f4b36d84670745f)
Base parent: 0c45ca3 (0c45ca314d60447c808f437c9df49ac81c0dc23d)

theemathas · 2026-08-09T12:58:11Z

@bors r=cuviper rollup=never p=1

rust-bors · 2026-08-09T12:58:14Z

📌 Commit ebcacaa has been approved by cuviper

It is now in the queue for this repository.

JonathanBrouwer · 2026-08-09T13:24:20Z

aarch64-apple is being slow but looks likely to still finish

rust-bors · 2026-08-09T13:51:14Z

☀️ Test successful - CI
Approved by: cuviper
Duration: 5h 24m 26s
Pushing e1114a1 to beta...

cuviper · 2026-08-09T19:47:11Z

returning slightly different artifacts non-deterministically?!

I wonder if it's not really hashing a tarball at all, but rather an HTTP error with headers (including timestamps).

mkroening and others added 3 commits August 4, 2026 16:03

rustfmt: Discover modules via cfg_select!

f8beb1e

(cherry picked from commit facc787)

Rename splat attribute to rustc_splat

2c57aef

(cherry picked from commit cb797b8)

rustbot assigned cuviper Aug 7, 2026

This comment has been minimized.

Sign in to view

teor2345 and others added 6 commits August 7, 2026 10:24

Appease tidy after auto rename

bb3726b

(cherry picked from commit bc1bb27)

Update attr name in #[unroll] codegen-llvm tests

5283510

(cherry picked from commit 44d291e)

Update attr name in #[unroll] ui tests

b01bcda

To account for the renamed `#[rustc_unroll]` attribute. (cherry picked from commit 91ee1f3)

Update attr name for #[unroll] in Unstable Book

33c0be1

(cherry picked from commit d1265b7)

cuviper force-pushed the beta-next branch from 555aa3d to 33c0be1 Compare August 7, 2026 17:24

[beta-1.98] Update cargo submodule

ebcacaa

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 7, 2026

cuviper mentioned this pull request Aug 7, 2026

[beta-1.98] Update cargo submodule #160596

Open

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 7, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 9, 2026

Auto merge of #160714 - cuviper:beta-next, r=<try>

5fe2984

[beta] backports try-job: dist-powerpc64-linux-musl try-job: dist-loongarch64-linux

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026

rust-bors Bot merged commit e1114a1 into rust-lang:beta Aug 9, 2026
15 checks passed

rustbot added this to the 1.98.0 milestone Aug 9, 2026

theemathas mentioned this pull request Aug 9, 2026

1.98 beta regression due to name collision with unroll #159429

Closed

Uh oh!

Uh oh!

Conversation

cuviper commented Aug 7, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Aug 7, 2026

Uh oh!

cuviper commented Aug 7, 2026

Uh oh!

rust-bors Bot commented Aug 7, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 7, 2026

Uh oh!

rust-bors Bot commented Aug 7, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

jieyouxu commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theemathas commented Aug 9, 2026

Uh oh!

jieyouxu commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Aug 9, 2026

Uh oh!

jieyouxu commented Aug 9, 2026

Uh oh!

jieyouxu commented Aug 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 9, 2026

Uh oh!

theemathas commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

JonathanBrouwer commented Aug 9, 2026

Uh oh!

rust-bors Bot commented Aug 9, 2026

Uh oh!

Uh oh!

cuviper commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cuviper commented Aug 7, 2026 •

edited by rustbot

Loading

jieyouxu commented Aug 9, 2026 •

edited

Loading

jieyouxu commented Aug 9, 2026 •

edited

Loading

jieyouxu commented Aug 9, 2026 •

edited

Loading