simplify MoveDataBuilder::move_path_for with new UnDerefer::co_iter_projections - #160784
Open
beepster4096 wants to merge 2 commits into
Open
simplify MoveDataBuilder::move_path_for with new UnDerefer::co_iter_projections#160784beepster4096 wants to merge 2 commits into
MoveDataBuilder::move_path_for with new UnDerefer::co_iter_projections#160784beepster4096 wants to merge 2 commits into
Conversation
this resolves some borrowck pains when using it
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
beepster4096
force-pushed
the
underefer_projection_coroutine
branch
from
August 9, 2026 00:38
8e94571 to
4dd8d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off an old design of #160780
MoveDataBuilder::move_path_forhas been kind of messy sinceDereferwas moved before drop elaboration because of borrowck problems with theUnDerefer::iter_projectionsiterator. This PR addsco_iter_projections, returning aProjectionCoroutinewhich takes a&UnDereferfor each iteration. Now,move_path_fordoesn't have an outlined copy ofadd_move_pathanymore which is a lot nicer.Since my other PR doesn't need this anymore, if its a perf regression I'll probably just close the PR.
Issues:
co_iter_projectionsis the best namePossible alternatives:
mem::takeonself.data.rev_lookup.un_derefer?