dump-mir was causing cycles by invoking item-path-str at bad times - #41777
Merged
Conversation
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
S-waiting-on-review
Contributor
|
Can you scope the thread-local just to the call to |
nikomatsakis
force-pushed
the
issue-41697-mir-dump-cycle
branch
from
May 8, 2017 19:45
325cf47 to
4f596a0
Compare
Contributor
Author
|
@arielb1 like that? |
Workaround for now, but probably a better fix is to opt **in** to using the types for impls (if we do that at all; maybe filename/line is better).
nikomatsakis
force-pushed
the
issue-41697-mir-dump-cycle
branch
from
May 8, 2017 19:59
4f596a0 to
cadf187
Compare
arielb1
added
S-waiting-on-bors
Contributor
|
Yup. |
Collaborator
|
📌 Commit cadf187 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
May 9, 2017
…elb1 dump-mir was causing cycles by invoking item-path-str at bad times Workaround for now, but probably a better fix is to opt **in** to using the types for impls (if we do that at all; maybe filename/line is better). Fixes #41697
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for now, but probably a better fix is to opt in to using the types for impls (if we do that at all; maybe filename/line is better).
Fixes #41697